Skip to content

[cleanup crusade] cleanup licenses#4136

Merged
ktsaou merged 4 commits intonetdata:masterfrom
paulfantom:legal
Sep 10, 2018
Merged

[cleanup crusade] cleanup licenses#4136
ktsaou merged 4 commits intonetdata:masterfrom
paulfantom:legal

Conversation

@paulfantom
Copy link
Contributor

Add info about SPDX usage to LICENSE file in accordance to SPDX guidelines: https://spdx.org/sites/cpstandard/files/pages/files/using_spdx_license_list_short_identifiers.pdf

And remove license templates as they are also listed in https://spdx.org/licenses/

DO NOT MERGE yet.

@paulfantom
Copy link
Contributor Author

Also fix Copyright year in REDISTRIBUTED.md per FSF guidelines: http://www.gnu.org/licenses/gpl-howto.html

@paulfantom paulfantom changed the title [WIP][cleanup crusade] cleanup licenses [cleanup crusade] cleanup licenses Sep 8, 2018
@paulfantom
Copy link
Contributor Author

Ready to merge

@ktsaou
Copy link
Member

ktsaou commented Sep 8, 2018

hm... are you sure we should not host the licenses? I thought we were supposed to provide these files in the packages we distribute.

@paulfantom
Copy link
Contributor Author

I was talking with Trevor King from SPDX org about it and there is no benefit of having those. It is more important to have "Copyright" line in particular files than those templates, identifier + info about what identifier means is enough.

Also with this we don't have to remember about including new license template when we are adding some new file.

Fun fact, I haven't found any file licensed with WTFPL, but we are still shipping this license template.

@ktsaou
Copy link
Member

ktsaou commented Sep 8, 2018

ok, let's wait for @Ferroin to review this.
He worked on making github understand our license (have this GPL-3.0 logo at the top of the repo home page), so let's give him a chance to review this.

@ktsaou
Copy link
Member

ktsaou commented Sep 8, 2018

@Ferroin I also added you as a collaborator. Strange... I didn't have done this all this time...

Copy link
Member

@Ferroin Ferroin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issues with it. Github's license detection should still recognize the project as GPL-3.0, as the text is about 97% the same as the GPL v3 based on the algorithm they use and most of the issue was the fact that they saw multiple things they thought were license files in the repository root.

@ktsaou
Copy link
Member

ktsaou commented Sep 10, 2018

so, merge?

@Ferroin
Copy link
Member

Ferroin commented Sep 10, 2018

Yep, LGTM.

@ktsaou ktsaou merged commit d0e74a5 into netdata:master Sep 10, 2018
@ktsaou
Copy link
Member

ktsaou commented Sep 10, 2018

merged!
Thank you @paulfantom !

@paulfantom paulfantom deleted the legal branch September 10, 2018 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants