Add permission file check in ceph module#4177
Merged
ktsaou merged 1 commit intonetdata:masterfrom Sep 12, 2018
Merged
Conversation
Contributor
|
LGTM, @l2isbad ? |
ilyam8
approved these changes
Sep 12, 2018
Member
|
LGTM |
Member
|
merged! thank you @lets00 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request add to ceph module verification about file permissions and if files exists, logging when netdata user does not permission to read the ceph configuration file and the ceph keyring file.
The pull request also fix a unit conversion bug (available and usage space were being shown in smaller unit (MB instead GB or GB instead TB))