Skip to content

properly parse network interface names with colon on them#4653

Merged
ktsaou merged 1 commit intonetdata:masterfrom
ktsaou:fix-iface-names
Nov 13, 2018
Merged

properly parse network interface names with colon on them#4653
ktsaou merged 1 commit intonetdata:masterfrom
ktsaou:fix-iface-names

Conversation

@ktsaou
Copy link
Member

@ktsaou ktsaou commented Nov 13, 2018

Summary

fixes #4536

This PR fixes 2 bugs:

  1. Network interface names may have a colon (:) in them. Netdata was incorrectly parsing these network interface names (: was assumed to be a separator).

    The effect of this was twofold:

    • the collected values was totally wrong (all values were shifted).
    • when interfaces sharing the same prefix, the same chart was updated multiple times per iteration, resulting in totally crazy values.
  2. Families that had : in them, resulted in DOM element IDs with : in them. This crashed jquery.

This PR fixed them both.

Component Name
Additional Information

@ktsaou ktsaou changed the title properly parse network interface names properly parse network interface names with colon on them Nov 13, 2018
@ktsaou
Copy link
Member Author

ktsaou commented Nov 13, 2018

@gmosx you have placed the NETDATA.name2id() function in compatibility.js which I think is not something about compatibility. We generally need this to properly convert strings to DOM element IDs.

@ktsaou ktsaou merged commit 78abc59 into netdata:master Nov 13, 2018
@ktsaou ktsaou deleted the fix-iface-names branch November 13, 2018 23:33
@gmosx
Copy link
Contributor

gmosx commented Nov 14, 2018

@gmosx you have placed the NETDATA.name2id() function in compatibility.js which I think is not something about compatibility. We generally need this to properly convert strings to DOM element IDs.

@ktsaou OK, I will move it to utils.js.

@paulfantom paulfantom added area/collectors Everything related to data collection area/web labels Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/collectors Everything related to data collection area/web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inbound packets dropped inbound

3 participants