properly parse network interface names with colon on them#4653
Merged
ktsaou merged 1 commit intonetdata:masterfrom Nov 13, 2018
Merged
properly parse network interface names with colon on them#4653ktsaou merged 1 commit intonetdata:masterfrom
ktsaou merged 1 commit intonetdata:masterfrom
Conversation
Member
Author
|
@gmosx you have placed the |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes #4536
This PR fixes 2 bugs:
Network interface names may have a colon (
:) in them. Netdata was incorrectly parsing these network interface names (:was assumed to be a separator).The effect of this was twofold:
Families that had
:in them, resulted in DOM element IDs with:in them. This crashed jquery.This PR fixed them both.
Component Name
Additional Information