Skip to content

Prevent netdata-updater.sh from sending cron report for git stash entries#4952

Merged
paulfantom merged 1 commit intonetdata:masterfrom
cakrit:netdata-updater
Dec 12, 2018
Merged

Prevent netdata-updater.sh from sending cron report for git stash entries#4952
paulfantom merged 1 commit intonetdata:masterfrom
cakrit:netdata-updater

Conversation

@cakrit
Copy link
Contributor

@cakrit cakrit commented Dec 8, 2018

Summary

Fixes: #4950

Component Name

installer

Additional Information

Separate the git pop command and capture its output. Show info message only if it exits with a 0

@cakrit cakrit requested a review from paulfantom December 8, 2018 12:14
@cakrit cakrit requested a review from ktsaou as a code owner December 8, 2018 12:14
Copy link
Member

@ktsaou ktsaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
But please wait for @paulfantom to review this before merging it.

@netdatabot netdatabot added the area/packaging Packaging and operating systems support label Dec 9, 2018
@paulfantom paulfantom merged commit 4b5d02a into netdata:master Dec 12, 2018
@cakrit cakrit deleted the netdata-updater branch January 10, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/packaging Packaging and operating systems support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants