smartd_log: skip non-CSVs early#5081
Merged
ilyam8 merged 1 commit intonetdata:masterfrom Dec 30, 2018
Merged
Conversation
|
|
ilyam8
approved these changes
Dec 30, 2018
Member
|
@kevlar1818 thanks for contributing 👍 |
Member
|
@kevlar1818 please sign the CLA |
netdatabot
added
area/collectors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The smartd_log plugin may see files that don't fit the expected CSV format, in which case the filename decomposition is likely to fail. We can move the "CSV file check" code earlier in the necessary code to avoid this.
Fixes #5079
Component Name
smartd_log plugin
Additional Information