Skip to content

varnish module: add instance_name option#5264

Merged
ilyam8 merged 3 commits intonetdata:masterfrom
ilyam8:varsnish_working_dir
Jan 31, 2019
Merged

varnish module: add instance_name option#5264
ilyam8 merged 3 commits intonetdata:masterfrom
ilyam8:varsnish_working_dir

Conversation

@ilyam8
Copy link
Member

@ilyam8 ilyam8 commented Jan 24, 2019

Summary

Fixes: #5262

Component Name

/collectors/python.d.plugin/varnish

Additional Information

Details in #5262 (comment)

@ilyam8 ilyam8 requested review from cakrit and ktsaou as code owners January 24, 2019 18:45
@ilyam8
Copy link
Member Author

ilyam8 commented Jan 24, 2019

@feld

please check the fix

@feld
Copy link

feld commented Jan 24, 2019

I will test it soon, but this looks correct:

        if self.instance_name:
	            self.command = [varnishstat, '-1', '-n', self.instance_name]
	        else:
	            self.command = [varnishstat, '-1']
	        return True

@ilyam8
Copy link
Member Author

ilyam8 commented Jan 24, 2019

@feld ye, it is an easy fix, and i am sure it will be working, but still better to check

@netdatabot netdatabot added area/collectors Everything related to data collection area/docs area/external/python labels Jan 24, 2019
@ilyam8
Copy link
Member Author

ilyam8 commented Jan 29, 2019

@feld any news on this?

cakrit
cakrit previously approved these changes Jan 29, 2019
@ilyam8
Copy link
Member Author

ilyam8 commented Jan 31, 2019

@cakrit please approve

@ilyam8 ilyam8 merged commit 9c334bb into netdata:master Jan 31, 2019
@ilyam8 ilyam8 deleted the varsnish_working_dir branch February 5, 2019 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/collectors Everything related to data collection area/docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

varnish plugin doesn't support custom varnishd working directory

4 participants