Fix curl download#5439
Merged
paulfantom merged 2 commits intonetdata:masterfrom Feb 20, 2019
Hufschmidt:fix-curl-download
Merged
Fix curl download#5439paulfantom merged 2 commits intonetdata:masterfrom Hufschmidt:fix-curl-download
paulfantom merged 2 commits intonetdata:masterfrom
Hufschmidt:fix-curl-download
Conversation
Hufschmidt
requested review from
cakrit,
ktsaou and
paulfantom
as code owners
|
|
cakrit
approved these changes
Feb 20, 2019
Contributor
cakrit
left a comment
cakrit
left a comment
There was a problem hiding this comment.
LGTM. I haven't tested, but I can't imagine what could go wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This should fix a minor installation/update issue when only curl is available during install/update as described in #5411.
Component Name
Additional Information
This PR adds the
-Largument to curl-calls in all instances ofdownload()used by thenetdata-installer.sh,netdata-updater.shandkickstart*.shscripts. This should cover all occurrences.I was wondering, why do kickstart.sh and kickstart-static64.sh not include/source functions.sh so we could share more code?EDIT: Ah ok, this is the single-file downloader/installer, makes sence! 😄
Additionally I noticed that the
.gitignorerules for the auto-generatednetdata-updater.shandnetdata-uninstaller.shalso matched files under /packaging/installer. This is not a huge issue, since.gitignoreonly affects uncommited files but might cause some headaches later down the line.Note: There might be more entries that could be changed to paths relative to the
.gitignorefile.