netdata/packaging/installer: Dont use --always in git describe.#5860
Merged
paulkatsoulakis merged 1 commit intonetdata:masterfrom Apr 13, 2019
Merged
Conversation
…t find a tag we have the alternative of packaging/version content file
cakrit
approved these changes
Apr 13, 2019
jackyhuang85
pushed a commit
to jackyhuang85/netdata
that referenced
this pull request
Jan 1, 2020
…t find a tag we have the alternative of packaging/version content file (netdata#5860)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dont use --always in git describe.
When git describe can't find a tag, we have the alternative of packaging/version content file.
When we use --always we break the configure mechanism and we end up with broken version information if git describe doesn't reach out to a tag (for example when a small number is given to --depth during git clone)
Component Name
netdata/packaging/installer
Additional Information
Fixes #5855