sidebar-info update - DB engine#6744
Merged
jacekkolasa merged 7 commits intonetdata:masterfrom Sep 12, 2019
Merged
Conversation
jacekkolasa
requested review from
mfundul,
thiagoftsm and
vlvkobal
as code owners
mfundul
previously approved these changes
Sep 2, 2019
vlvkobal
previously approved these changes
Sep 2, 2019
thiagoftsm
previously approved these changes
Sep 2, 2019
Contributor
thiagoftsm
left a comment
thiagoftsm
left a comment
There was a problem hiding this comment.
Hi @jacekkolasa ,
I tested now the changes that you did using FreeBSD 12.0-release-p10 and dbengine, everything worked as expected where we had the new variable present in the report and the JS did not report any error, so LGTM! :)
jacekkolasa
dismissed stale reviews from thiagoftsm, vlvkobal, and mfundul
via
5909526
jacekkolasa
force-pushed
the
sidebar-dbengine-conditional
branch
from
df3dae8 to
95db5ff
Compare
jacekkolasa
changed the title
cosmix
reviewed
Sep 5, 2019
thiagoftsm
previously approved these changes
Sep 11, 2019
Contributor
thiagoftsm
left a comment
thiagoftsm
left a comment
There was a problem hiding this comment.
I have tested this PR again, this time on Slackware current and I verified that it is working well.
Congratulations @jacekkolasa !
…utes, and # seconds of real-time history."
jacekkolasa
force-pushed
the
sidebar-dbengine-conditional
branch
from
6243280 to
baf8039
Compare
mfundul
approved these changes
Sep 12, 2019
vlegakis
approved these changes
Sep 12, 2019
vlegakis
left a comment
vlegakis
left a comment
There was a problem hiding this comment.
LGTM.
Just a note only: perhaps we could introduce a more automated cache buster-versioning system.
| <meta name="twitter:image" content="https://cloud.githubusercontent.com/assets/2662304/14092712/93b039ea-f551-11e5-822c-beadbf2b2a2e.gif" /> | ||
|
|
||
| <script src="main.js?v20190902-0"></script> | ||
| <script src="main.js?v20190905-0"></script> |
There was a problem hiding this comment.
Nice! Perhaps we could introduce a mode standard and more automated cache buster logic though, like we do in the cloud (console project)
Contributor
Author
There was a problem hiding this comment.
thanks for mentioning that, i'll check current cloud solutions. i think we can think about cache when we'll do build/compile task for the new dashboard
Saruspete
pushed a commit
to Saruspete/netdata
that referenced
this pull request
Oct 9, 2019
* remove "Netdata is using # MB of memory on HOSTNAME for # hour, # minutes, and # seconds of real-time history." * Added "memory_mode" key to the get "charts" API call * don't show db engine tip when user has it already installed * add back hostname information * add oxford comma (only for db-engine users) * update main.js hash * <b> --> <strong> (but only in sidebar info, main.js)
jackyhuang85
pushed a commit
to jackyhuang85/netdata
that referenced
this pull request
Jan 1, 2020
* remove "Netdata is using # MB of memory on HOSTNAME for # hour, # minutes, and # seconds of real-time history." * Added "memory_mode" key to the get "charts" API call * don't show db engine tip when user has it already installed * add back hostname information * add oxford comma (only for db-engine users) * update main.js hash * <b> --> <strong> (but only in sidebar info, main.js)
Saruspete
pushed a commit
to Saruspete/netdata
that referenced
this pull request
May 21, 2020
* remove "Netdata is using # MB of memory on HOSTNAME for # hour, # minutes, and # seconds of real-time history." * Added "memory_mode" key to the get "charts" API call * don't show db engine tip when user has it already installed * add back hostname information * add oxford comma (only for db-engine users) * update main.js hash * <b> --> <strong> (but only in sidebar info, main.js)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves #6734
Summary
User should not see the DB tip on the sidebar, when he/she already configured db engine. (on the host level, for now)
Additionally,
Netdata is using ** of memory on **for ** minutes and ** seconds of real-time history.sentence should be removedComponent Name
Web