Skip to content

Conversation

@aedwardstx
Copy link
Collaborator

@aedwardstx aedwardstx commented Nov 16, 2024

Changes

  • Abstract the two children list and dict collections into a single class.
  • Relax pydantic pinning a little.
  • In _difference(), consider sectional_overwrite first and do not add subtree just to delete it.
  • Add return_if_present and check_if_present args to add_child().
  • Simplify call to config_to_get_to().
  • Rework __eq__() methods of HConfig related objects.
  • Use TypeVar to remove the need to do 3 isinstance() checks.
  • Remove need to do a second children.get() in add_children_deep().
  • Simplify overwrite_with() logic.
  • Various test improvements.

@aedwardstx aedwardstx added the enhancement New feature or request label Nov 16, 2024
@aedwardstx aedwardstx self-assigned this Nov 16, 2024
@aedwardstx aedwardstx changed the title Abstract children list and dict collections into a class Draft: Abstract children list and dict collections into a class Nov 16, 2024
@aedwardstx aedwardstx changed the title Draft: Abstract children list and dict collections into a class Abstract children list and dict collections into a class Nov 19, 2024
@jtdub jtdub self-requested a review November 20, 2024 15:35
jtdub
jtdub previously approved these changes Nov 20, 2024
Copy link
Contributor

@jtdub jtdub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming Reese's comments are addressed, it LGTM!.

@aedwardstx aedwardstx merged commit ff0794a into netdevops:master Nov 20, 2024
@aedwardstx aedwardstx deleted the children_class branch November 20, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants