Skip to content

fix drift alert#106

Merged
nicoalba merged 4 commits into
mainfrom
drift-fix
May 28, 2026
Merged

fix drift alert#106
nicoalba merged 4 commits into
mainfrom
drift-fix

Conversation

@nicoalba
Copy link
Copy Markdown
Contributor

@nicoalba nicoalba commented May 28, 2026

No description provided.

… in mattermost action

The action routes to addPushDetails() when no schedule field is present,
then crashes on the missing 'forced' key. Mirroring the notify-mattermost
job's pattern fixes the routing.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
nf-theme-sandbox Ignored Ignored Preview May 28, 2026 12:46am
unified-doc-preview Ignored Ignored Preview May 28, 2026 12:46am

Request Review

nicoalba and others added 2 commits May 28, 2026 00:29
The action reads GITHUB_EVENT_NAME from the environment to route event
handling. On push-triggered builds it calls addPushDetails(), which
requires push-specific fields (forced, commits, ref, compare) that our
custom drift-context JSON does not provide. Push failures are visible to
the pusher in CI; the unattended nightly schedule is what needs the alert.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Left over from an earlier wrong fix attempt.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@nicoalba nicoalba changed the title fix drift alert: add schedule field to event JSON to prevent KeyError… fix drift alert May 28, 2026
@nicoalba nicoalba merged commit 07d2544 into main May 28, 2026
7 checks passed
@nicoalba nicoalba deleted the drift-fix branch May 28, 2026 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants