Skip to content

Conversation

@tenhobi
Copy link
Member

@tenhobi tenhobi commented Jan 8, 2026

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

DCM report

✅ no issues found!

Full report: https://github.com/netglade/flutter_core/runs/59767331308

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates DCM (Dart Code Metrics) from version 1.33.0 to 1.35.0, incorporating new lint rules and updating test files to comply with the new linting requirements, particularly the prefer-test-structure rule which enforces the Arrange-Act-Assert (AAA) pattern.

  • Updates DCM version to 1.35.0 and adds 4 new lint rules
  • Modifies maintainability-index metric from 50 to 0.5 to align with DCM's updated configuration format
  • Restructures test files to follow the AAA pattern with explicit comment sections

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
dcm_global.yaml Updates DCM version from 1.33.0 to 1.35.0
packages/netglade_analysis/pubspec.yaml Bumps package version to 21.0.0
packages/netglade_analysis/lib/dcm.yaml Adds 4 new lint rules and updates maintainability-index metric to 0.5
packages/netglade_analysis/CHANGELOG.md Documents changes for version 21.0.0
packages/netglade_analysis/README.md Updates version reference to 21.0.0
packages/netglade_utils/pubspec.yaml Updates netglade_analysis dependency to ^21.0.0
packages/netglade_utils/example/pubspec.yaml Updates netglade_analysis dependency to ^21.0.0
packages/netglade_flutter_utils/pubspec.yaml Updates netglade_analysis dependency to ^21.0.0
packages/netglade_flutter_utils/example/pubspec.yaml Updates netglade_analysis dependency to ^21.0.0
packages/netglade_utils/test/src/extensions/string_extensions_test.dart Restructures tests to follow AAA pattern with explicit comments
packages/netglade_utils/test/src/extensions/date_time_extensions_test.dart Restructures tests to follow AAA pattern and converts forEach to for-in loops

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tenhobi tenhobi merged commit 13f47c5 into main Jan 14, 2026
2 checks passed
@tenhobi tenhobi deleted the feat/netglade_analysis_21.0.0 branch January 14, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants