Skip to content

[NAE-1931] Implementation of Index Re-Creation after MongoDB Database Drop#231

Merged
machacjozef merged 6 commits into
release/6.3.3from
NAE-1931
Dec 14, 2023
Merged

[NAE-1931] Implementation of Index Re-Creation after MongoDB Database Drop#231
machacjozef merged 6 commits into
release/6.3.3from
NAE-1931

Conversation

@timbez

@timbez timbez commented Dec 12, 2023

Copy link
Copy Markdown
Contributor
  • extend mongodb runner
  • add new properties

Description

ensure that mongo indices/indexes are created even after collections are dropped via runner

Fixes NAE-1931

Dependencies

Should be merged with #232 for best outcome (required for LDAP)

Docs:
https://docs.spring.io/spring-data/mongodb/reference/mongodb/mapping/mapping-index-management.html

Third party dependencies

none

Blocking Pull requests

none

How Has Been This Tested?

manual testing (run on existing DB and check indexes for mongo collections)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @...
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

@timbez timbez added the bugfix A change that fixes a bug label Dec 12, 2023
@timbez timbez requested review from machacjozef and tuplle December 12, 2023 11:35
@timbez timbez self-assigned this Dec 12, 2023
@timbez timbez changed the base branch from master to release/6.3.3 December 12, 2023 11:35
tuplle
tuplle previously approved these changes Dec 13, 2023
@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 62 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Small
Size       : +42 -20
Percentile : 24.8%

Total files changed: 4

Change summary by file extension:
.groovy : +20 -0
.java : +20 -20
.properties : +2 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@sonarqubecloud

Copy link
Copy Markdown

@machacjozef machacjozef merged commit b6f33fa into release/6.3.3 Dec 14, 2023
@machacjozef machacjozef deleted the NAE-1931 branch December 14, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix A change that fixes a bug Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants