Skip to content

[NAE-1936] Disable create case button using menu items#235

Merged
renczesstefan merged 2 commits into
NAE-1906from
NAE-1936
Jan 23, 2024
Merged

[NAE-1936] Disable create case button using menu items#235
renczesstefan merged 2 commits into
NAE-1906from
NAE-1936

Conversation

@martinkranec

@martinkranec martinkranec commented Jan 3, 2024

Copy link
Copy Markdown
Contributor

Description

added param to default-case-view and default-tab-view that checks if create case button is shown

Implements NAE-1936

Dependencies

No new dependencies were introduced.

Third party dependencies

  • No new dependencies were introduced.

Blocking Pull requests

There are no dependencies on other PR.

How Has Been This Tested?

Tested manually

Test Configuration

Name Tested on
OS Windows 11
Runtime Java 11
Dependency Manager Maven 3.3.0
Framework version Spring boot 2.7.8
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @Retoocs
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides

- added param to preference_item.xml that checks if create case button is shown in case view
@martinkranec martinkranec self-assigned this Jan 3, 2024
@martinkranec martinkranec changed the base branch from master to NAE-1906 January 3, 2024 15:18
@martinkranec martinkranec marked this pull request as draft January 3, 2024 15:38
@martinkranec martinkranec requested a review from Retoocs January 3, 2024 16:02
- added new param to menu item body and constants
@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 28 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +27 -1
Percentile : 11.2%

Total files changed: 3

Change summary by file extension:
.java : +4 -0
.xml : +23 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@sonarqubecloud

sonarqubecloud Bot commented Jan 5, 2024

Copy link
Copy Markdown

@martinkranec martinkranec marked this pull request as ready for review January 10, 2024 12:15
@renczesstefan renczesstefan merged commit 9e7c988 into NAE-1906 Jan 23, 2024
@renczesstefan renczesstefan deleted the NAE-1936 branch January 23, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants