[NAE-1956] setData fails on setting allowedNets without value key#251
Conversation
- fix the problem with setting allowed nets without value, there was checking the validation of the value, so i add nullcheck
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
| changedField.setId(fieldId); | ||
| changedField.addAttribute("value", newValue); | ||
| Object newValue = parseFieldsValues(entry.getValue(), dataField); | ||
| if (newValue != null) { |
There was a problem hiding this comment.
if I remember correctly, there is a feature, that setting a value to null changes it to the initial value of the data variable (if specified). Does this feature exist? If yes, does it still work after this change?
- changes according to PR
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
- fix result of test
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Description
Fixes NAE-1956
Dependencies
none
Third party dependencies
No new dependencies were introduced
Blocking Pull requests
There are no dependencies on other PR
How Has Been This Tested?
manually
Test Configuration
Checklist: