Skip to content

[NAE-2009] Update actions for v7.0.0#272

Merged
machacjozef merged 12 commits into
release/7.0.0from
NAE-2009
Nov 12, 2024
Merged

[NAE-2009] Update actions for v7.0.0#272
machacjozef merged 12 commits into
release/7.0.0from
NAE-2009

Conversation

@renczesstefan

@renczesstefan renczesstefan commented Oct 10, 2024

Copy link
Copy Markdown
Member

Description

Implements NAE-2009

Dependencies

No new dependencies were introduced.

Third party dependencies

No new dependencies were introduced.

Blocking Pull requests

Depends on #268

How Has Been This Tested?

This was tested manually, and with unit tests.

Test Configuration

Name Tested on
OS macOS Sequoia 15.0
Runtime Java 11
Dependency Manager Maven 3.9.9n
Framework version Spring Boot 2.7.17
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @machacjozef
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

- removed unneccessary dto classes
- added serialization
- modified menu item
- added UriServiceConfiguration
- updated findCase queries
@renczesstefan renczesstefan self-assigned this Oct 10, 2024
@renczesstefan renczesstefan changed the base branch from release/7.0.0 to NAE-1975 October 10, 2024 10:12
@renczesstefan renczesstefan changed the base branch from NAE-1975 to release/7.0.0 October 10, 2024 10:13
renczesnetgrif and others added 5 commits October 15, 2024 11:48
# Conflicts:
#	src/main/java/com/netgrif/application/engine/workflow/service/DataService.java
#	src/main/java/com/netgrif/application/engine/workflow/service/interfaces/IDataService.java
#	src/test/groovy/com/netgrif/application/engine/petrinet/domain/dataset/FileFieldTest.groovy
- Changed uri service for default
- updated template.drl
@machacjozef machacjozef self-assigned this Nov 11, 2024
Comment thread pom.xml
@@ -392,35 +392,46 @@
</dependency>

<!-- Drools -->

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented lines may be removed.

Comment thread pom.xml
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<version>3.3.1</version>
<!-- <executions>-->

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a problem at build. Maven plugin failed, because it detected that this execution is duplicate, so I commented it out, but this must be fixed, or the sources will not be attached.

@@ -0,0 +1,81 @@
package com.netgrif.application.engine.integration.plugins.services

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can be deleted.

protected boolean ldapEnabled;

@Bean
@ConditionalOnMissingBean

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this solution may would be good to think about other solution - some kind of config, that tells, which bean to use, this could be defined with some key.

@@ -1,72 +1,72 @@
package com.netgrif.application.engine.configuration.drools;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed.

@@ -1,143 +1,143 @@
package com.netgrif.application.engine.configuration.drools;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed.

@@ -1,51 +1,51 @@
package com.netgrif.application.engine.configuration.drools;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed.

@@ -1,8 +1,8 @@
package com.netgrif.application.engine.configuration.drools.throwable;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these drools classes can be removed.

@@ -0,0 +1,58 @@
package com.netgrif.application.engine.integration.plugins.config;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be an old implementation of plugins. It is now solved through gRPC and with PF4J. These classes should be reviewed.

@dpulls

dpulls Bot commented Nov 12, 2024

Copy link
Copy Markdown

🎉 All dependencies have been resolved !

@machacjozef machacjozef merged commit 14db6bf into release/7.0.0 Nov 12, 2024
@machacjozef machacjozef deleted the NAE-2009 branch November 12, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants