Skip to content

[NAE-2099] MenuItemService.appendChildCaseIdInDataSet not setting hasChildren correctly#305

Merged
mazarijuraj merged 1 commit intorelease/6.5.0from
NAE-2099
May 12, 2025
Merged

[NAE-2099] MenuItemService.appendChildCaseIdInDataSet not setting hasChildren correctly#305
mazarijuraj merged 1 commit intorelease/6.5.0from
NAE-2099

Conversation

@martinkranec
Copy link
Contributor

@martinkranec martinkranec commented May 9, 2025

Description

Fixes the condition for setting the field hasChildren correctly. Added condition to check if newValue is not empty.

Fixes NAE-2099

Dependencies

No new dependencies were introduced

Third party dependencies

No new dependencies were introduced

Blocking Pull requests

There are no dependencies on other PR

How Has Been This Tested?

Manually on an already existing project.

Test Configuration

Name Tested on
OS Windows 11
Runtime Oracle OpenJDK 11.0.25
Dependency Manager Maven 3.9.9
Framework version Spring Boot 2.7.18
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @...
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

@martinkranec martinkranec self-assigned this May 9, 2025
@martinkranec martinkranec added the bugfix A change that fixes a bug label May 9, 2025
@Retoocs
Copy link
Contributor

Retoocs commented May 12, 2025

good job for finding it, thanks!

@mazarijuraj mazarijuraj merged commit c6febb8 into release/6.5.0 May 12, 2025
5 of 6 checks passed
@mazarijuraj mazarijuraj deleted the NAE-2099 branch May 12, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix A change that fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants