[NAE-2099] MenuItemService.appendChildCaseIdInDataSet not setting hasChildren correctly#305
Merged
mazarijuraj merged 1 commit intorelease/6.5.0from May 12, 2025
Merged
[NAE-2099] MenuItemService.appendChildCaseIdInDataSet not setting hasChildren correctly#305mazarijuraj merged 1 commit intorelease/6.5.0from
mazarijuraj merged 1 commit intorelease/6.5.0from
Conversation
…Children correctly - fix condition
mazarijuraj
approved these changes
May 12, 2025
Retoocs
approved these changes
May 12, 2025
Contributor
|
good job for finding it, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the condition for setting the field hasChildren correctly. Added condition to check if newValue is not empty.
Fixes NAE-2099
Dependencies
No new dependencies were introduced
Third party dependencies
No new dependencies were introduced
Blocking Pull requests
There are no dependencies on other PR
How Has Been This Tested?
Manually on an already existing project.
Test Configuration
Checklist: