Skip to content

Remove custom serializers for startDate in ElasticTask#342

Merged
machacjozef merged 1 commit intorelease/6.4.2from
fix/elastic_tailing_zero_bug
Aug 22, 2025
Merged

Remove custom serializers for startDate in ElasticTask#342
machacjozef merged 1 commit intorelease/6.4.2from
fix/elastic_tailing_zero_bug

Conversation

@renczesstefan
Copy link
Member

@renczesstefan renczesstefan commented Aug 21, 2025

Description

The custom JsonSerialize and JsonDeserialize annotations for startDate were removed. Elastic's FieldType.Date with the specified format handles the serialization/deserialization, making the custom serializers redundant. This simplifies the code and reduces unnecessary dependencies.

Dependencies

No new dependencies were introduced

Third party dependencies

No new dependencies were introduced

Blocking Pull requests

There are no dependencies on other PR

How Has Been This Tested?

Tested manually.

Test Configuration

Name Tested on
OS macOS Sequoia 15.3.1
Runtime Java 21
Dependency Manager Maven 3.9.9n
Framework version Spring Boot 3.2.5
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @...
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

Summary by CodeRabbit

  • New Features
    • Standardized task start date handling in search/indexed data, aligning with a precise date-time format.
  • Bug Fixes
    • Resolved inconsistencies in how task start dates are serialized, improving reliability of sorting, filtering, and display across the app and integrations.
  • Chores
    • Simplified date serialization configuration to reduce potential mismatch between application and search index date formats.

The custom JsonSerialize and JsonDeserialize annotations for startDate were removed. Elastic's FieldType.Date with the specified format handles the serialization/deserialization, making the custom serializers redundant. This simplifies the code and reduces unnecessary dependencies.
@renczesstefan renczesstefan self-assigned this Aug 21, 2025
@renczesstefan renczesstefan added bugfix A change that fixes a bug Extra Small labels Aug 21, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 21, 2025

Walkthrough

Removed Jackson serialization/deserialization annotations from ElasticTask.startDate, retaining only the Elasticsearch date field mapping. No other fields or mappings changed.

Changes

Cohort / File(s) Summary of Changes
Elasticsearch mapping and JSON serialization
src/main/java/com/netgrif/application/engine/elastic/domain/ElasticTask.java
Removed @JsonSerialize and @JsonDeserialize on startDate; kept @field(type = Date, format = date_hour_minute_second_millis). No other edits.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 62355cb and 867240b.

📒 Files selected for processing (1)
  • src/main/java/com/netgrif/application/engine/elastic/domain/ElasticTask.java (0 hunks)
💤 Files with no reviewable changes (1)
  • src/main/java/com/netgrif/application/engine/elastic/domain/ElasticTask.java
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: task-list-completed
  • GitHub Check: task-list-completed
  • GitHub Check: Build
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/elastic_tailing_zero_bug

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@machacjozef machacjozef requested a review from Retoocs August 22, 2025 08:29
@machacjozef machacjozef merged commit 14eeaa1 into release/6.4.2 Aug 22, 2025
6 of 7 checks passed
@machacjozef machacjozef deleted the fix/elastic_tailing_zero_bug branch August 22, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix A change that fixes a bug Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants