Skip to content

Nae 1572 - FilterImportExportService service does not assign import_filter tasks#4

Merged
machacjozef merged 2 commits intorelease/6.0.2from
NAE-1572
Feb 16, 2022
Merged

Nae 1572 - FilterImportExportService service does not assign import_filter tasks#4
machacjozef merged 2 commits intorelease/6.0.2from
NAE-1572

Conversation

@camperko
Copy link
Copy Markdown
Member

@camperko camperko commented Feb 16, 2022


Instruction for the developer

For starters, congratulation on opening a PR of your work. I hope you're proud of your work and yourself 😉 .
There are some things you need to do before this PR is submitted, so read carefully.

First, set yourself as an assignee. You can also add other people responsible for code in this PR (i.e. your team lead).

Then set reviewers. There should be at least two reviewers. You can set your team lead, projects owner, or senior developer
(after his or her agreement, of course) as a PR reviewer.

The last element on the right panel are labels. Labels should be based on what type of change the PR brings to the table.
You can add one or more labels that apply to the PR:

  • Bugfix (a change that fixes a bug)
  • New feature (a change that introduces new functionality)
  • Improvement (a change that improves on an existing feature)
  • Breaking change (fix or feature that would cause existing functionality doesn't work as expected)
  • Documentation update (a change makes, or requires, change to the product documentation)
  • New Dependency (a change that introduces new third-party dependency)
  • Critical (a change that is critical to a release and must not be omitted)

Next thing, please read and edit the PR description below the following way:

  • If a statement is between < > symbols, replace it with your content according to the instructions in the statement.
  • If a slash / is between two statements, choose to fill only one or the other.
  • To reference a JIRA issue, use the issue key wrapped by [ ] brackets.
  • To mention someone (or team), use at @ symbol.
  • To reference specific code, use an absolute link to the source code file with suffix #L and the number of the desired line of code.

For whole markdown documentation please read GitHub Markdown.

If you read these whole instructions and have done everything, you are the best 👍 .
You can now safely delete all between two horizontal lines, so the instructions don't look bad in your PR.


Description

<Fixes [JIRA-ISSUE]>/<Implements [JIRA-ISSUE]>

Dependencies

Third party dependencies

Blocking Pull requests

<Depends on #(PR id)>/

How Has Been This Tested?

  • <Name of a test [test file](link to the test file)>

Test Configuration

<Please describe configuration for tests to run if applicable, like program parameters, host OS, VM configuration etc.>

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @...
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

Jozef Daxner added 2 commits February 16, 2022 14:21
…ilter tasks

- assign import_filter tasks before finishing them in import filters process
@pull-request-quantifier-deprecated
Copy link
Copy Markdown

This PR has 18 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +11 -7
Percentile : 7.2%

Total files changed: 4

Change summary by file extension:
.java : +11 -7

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@camperko camperko requested a review from machacjozef February 16, 2022 13:38
@camperko camperko self-assigned this Feb 16, 2022
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@camperko camperko changed the title Nae 1572 Nae 1572 - FilterImportExportService service does not assign import_filter tasks Feb 16, 2022
@machacjozef machacjozef merged commit f6cdd0d into release/6.0.2 Feb 16, 2022
@machacjozef machacjozef deleted the NAE-1572 branch May 26, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants