[NAE-2217] Single Task View #303
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| import {InjectionToken} from '@angular/core'; | ||
| import {TaskContentServiceType} from './task-content-service-type'; | ||
|
|
||
| export const NAE_TASK_CONTENT_SERVICE_TYPE = new InjectionToken<TaskContentServiceType>('NaeTaskContentServiceType'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| export enum TaskContentServiceType { | ||
| /** | ||
| * Type for creating SingleTaskContentService | ||
| */ | ||
| SINGLE = 'single', | ||
| /** | ||
| * Type for creating UnlimitedTaskContentService | ||
| */ | ||
| UNLIMITED = 'unlimited' | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ export * from './services/field-converter.service'; | |
| export * from './services/task-content.service'; | ||
| export * from './services/single-task-content.service'; | ||
| export * from './services/unlimited-task-content.service'; | ||
| export * from './services/task-content-service-factory'; | ||
|
|
||
| /* MODELS */ | ||
| export * from './model/policy'; | ||
|
|
@@ -17,6 +18,8 @@ export * from './model/async-rendering-configuration-injection-token'; | |
| export * from './model/subgrid'; | ||
| export * from './model/split-data-group'; | ||
| export * from './model/task-fields'; | ||
| export * from './model/task-content-service-type'; | ||
| export * from './model/task-content-injection-token'; | ||
|
|
||
| /* MODULES */ | ||
| export * from './task-content/abstract-task-content.component'; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,28 @@ | ||||||||||||||||||||||||||||||||||||||||||||||
| import {Injectable, Injector} from "@angular/core"; | ||||||||||||||||||||||||||||||||||||||||||||||
| import {LoggerService} from "../../logger/services/logger.service"; | ||||||||||||||||||||||||||||||||||||||||||||||
| import {FieldConverterService} from "./field-converter.service"; | ||||||||||||||||||||||||||||||||||||||||||||||
| import {SnackBarService} from "../../snack-bar/services/snack-bar.service"; | ||||||||||||||||||||||||||||||||||||||||||||||
| import {TranslateService} from "@ngx-translate/core"; | ||||||||||||||||||||||||||||||||||||||||||||||
| import {SingleTaskContentService} from "./single-task-content.service"; | ||||||||||||||||||||||||||||||||||||||||||||||
| import {UnlimitedTaskContentService} from "./unlimited-task-content.service"; | ||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||
| @Injectable({ | ||||||||||||||||||||||||||||||||||||||||||||||
| providedIn: 'root' | ||||||||||||||||||||||||||||||||||||||||||||||
| }) | ||||||||||||||||||||||||||||||||||||||||||||||
| export class TaskContentServiceFactory { | ||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||
| constructor(protected _fieldConverterService: FieldConverterService, | ||||||||||||||||||||||||||||||||||||||||||||||
| protected _snackBarService: SnackBarService, | ||||||||||||||||||||||||||||||||||||||||||||||
| protected _translate: TranslateService, | ||||||||||||||||||||||||||||||||||||||||||||||
| protected _log: LoggerService, | ||||||||||||||||||||||||||||||||||||||||||||||
| protected _injector: Injector) { | ||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||
| public createSingleTaskContentService(): SingleTaskContentService { | ||||||||||||||||||||||||||||||||||||||||||||||
| return new SingleTaskContentService(this._fieldConverterService, this._snackBarService, this._translate, this._log, this._injector); | ||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||
| public createUnlimitedTaskContentService(): UnlimitedTaskContentService { | ||||||||||||||||||||||||||||||||||||||||||||||
| return new UnlimitedTaskContentService(this._fieldConverterService, this._snackBarService, this._translate, this._log, this._injector); | ||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+21
to
+27
There was a problem hiding this comment. 🧹 Nitpick | 🔵 Trivial Consider adding JSDoc for public factory methods. The factory methods are well-implemented and follow Angular patterns. Consider adding JSDoc comments to document when each service type should be used: + /**
+ * Creates a SingleTaskContentService instance.
+ * Use for components that should display only one task at a time (e.g., task lists).
+ */
public createSingleTaskContentService(): SingleTaskContentService {
return new SingleTaskContentService(this._fieldConverterService, this._snackBarService, this._translate, this._log, this._injector);
}
+ /**
+ * Creates an UnlimitedTaskContentService instance.
+ * Use for components that can display multiple tasks simultaneously (e.g., single task views).
+ */
public createUnlimitedTaskContentService(): UnlimitedTaskContentService {
return new UnlimitedTaskContentService(this._fieldConverterService, this._snackBarService, this._translate, this._log, this._injector);
}📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,3 +59,5 @@ export * from './tree-case-view/tree-component/remove-node/abstract-remove-node. | |
| export * from './tree-case-view/tree-task-content/abstract-tree-task-content.component'; | ||
| export * from './task-view/abstract-single-task-view.component'; | ||
| export * from './task-view/abstract-tabbed-single-task-view.component'; | ||
| export * from './task-view/components/task-panel-list/abstract-task-list.component'; | ||
| export * from './task-view/components/task-panel-list-pagination/abstract-task-list-pagination.component'; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| import {Component, EventEmitter, Input, Output} from '@angular/core'; | ||
| import {AbstractViewWithHeadersComponent} from '../abstract/view-with-headers'; | ||
| import {Observable} from 'rxjs'; | ||
| import {TaskPanelData} from '../../panel/task-panel-data/task-panel-data'; | ||
| import {TaskViewService} from './service/task-view.service'; | ||
| import {ActivatedRoute} from '@angular/router'; | ||
| import {map, tap} from "rxjs/operators"; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| import {Observable} from 'rxjs'; | ||
| import {Component, OnDestroy} from '@angular/core'; | ||
| import {TaskPanelData} from '../../panel/task-panel-data/task-panel-data'; | ||
| import {TaskViewService} from './service/task-view.service'; | ||
| import {AbstractViewWithHeadersComponent} from '../abstract/view-with-headers'; | ||
| import { ActivatedRoute } from '@angular/router'; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,16 @@ | ||
| import {MatExpansionPanel} from '@angular/material/expansion'; | ||
| import {ActivatedRoute} from '@angular/router'; | ||
| import {filter} from 'rxjs/operators'; | ||
| import {TabbedVirtualScrollComponent} from '../../../../panel/abstract/tabbed-virtual-scroll.component'; | ||
| import {AfterViewInit, Component, EventEmitter, Inject, Input, OnDestroy, Optional, Output} from '@angular/core'; | ||
| import {Observable, Subject, Subscription} from 'rxjs'; | ||
| import {TaskPanelData} from '../../../../panel/task-panel-data/task-panel-data'; | ||
| import {HeaderColumn} from '../../../../header/models/header-column'; | ||
| import {TaskEventNotification} from '../../../../task-content/model/task-event-notification'; | ||
| import {TaskViewService} from '../../service/task-view.service'; | ||
| import {LoggerService} from '../../../../logger/services/logger.service'; | ||
| import {NAE_TAB_DATA} from '../../../../tabs/tab-data-injection-token/tab-data-injection-token'; | ||
| import {InjectedTabData} from '../../../../tabs/interfaces'; | ||
|
|
||
|
|
||
| @Component({ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,11 +3,11 @@ import {Observable} from 'rxjs'; | |
| import {tap} from 'rxjs/operators'; | ||
| import {ActivatedRoute} from '@angular/router'; | ||
| import {AbstractDefaultTaskListComponent} from '../default-task-panel-list/abstract-default-task-list.component'; | ||
| import {TaskPanelData} from '../../../../panel/task-panel-data/task-panel-data'; | ||
| import {TaskViewService} from '../../service/task-view.service'; | ||
| import {LoggerService} from '../../../../logger/services/logger.service'; | ||
| import {NAE_TAB_DATA} from '../../../../tabs/tab-data-injection-token/tab-data-injection-token'; | ||
| import {InjectedTabData} from '../../../../tabs/interfaces'; | ||
|
|
||
| @Component({ | ||
| selector: 'ncc-abstract-task-list-pagination-component', | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,27 +7,27 @@ import {RouterTestingModule} from '@angular/router/testing'; | |
| import {Component, Inject, Optional} from '@angular/core'; | ||
| import {of} from 'rxjs'; | ||
| import {AbstractTaskListComponent} from './abstract-task-list.component'; | ||
| import {AssignPolicy, DataFocusPolicy, FinishPolicy} from '../../../../task-content/model/policy'; | ||
| import {TaskResourceService} from '../../../../resources/engine-endpoint/task-resource.service'; | ||
| import {MaterialModule} from '../../../../material/material.module'; | ||
| import {AuthenticationMethodService} from '../../../../authentication/services/authentication-method.service'; | ||
| import {MockAuthenticationMethodService} from '../../../../utility/tests/mocks/mock-authentication-method-service'; | ||
| import {AuthenticationService} from '../../../../authentication/services/authentication/authentication.service'; | ||
| import {MockAuthenticationService} from '../../../../utility/tests/mocks/mock-authentication.service'; | ||
| import {UserResourceService} from '../../../../resources/engine-endpoint/user-resource.service'; | ||
| import {MockUserResourceService} from '../../../../utility/tests/mocks/mock-user-resource.service'; | ||
| import {SearchService} from '../../../../search/search-service/search.service'; | ||
| import {TestTaskBaseFilterProvider, TestTaskViewAllowedNetsFactory} from '../../../../utility/tests/test-factory-methods'; | ||
| import {ConfigurationService} from '../../../../configuration/configuration.service'; | ||
| import {TestConfigurationService} from '../../../../utility/tests/test-config'; | ||
| import {TaskViewService} from '../../service/task-view.service'; | ||
| import {LoggerService} from '../../../../logger/services/logger.service'; | ||
| import {TranslateLibModule} from '../../../../translate/translate-lib.module'; | ||
| import {NAE_TAB_DATA} from '../../../../tabs/tab-data-injection-token/tab-data-injection-token'; | ||
| import {InjectedTabData} from '../../../../tabs/interfaces'; | ||
| import {NAE_BASE_FILTER} from '../../../../search/models/base-filter-injection-token'; | ||
| import {AllowedNetsService} from '../../../../allowed-nets/services/allowed-nets.service'; | ||
| import {AllowedNetsServiceFactory} from '../../../../allowed-nets/services/factory/allowed-nets-service-factory'; | ||
| import {ActivatedRoute} from '@angular/router'; | ||
|
|
||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| import {Component, Inject, Input, Optional, ViewChild} from '@angular/core'; | ||
| import {CdkVirtualScrollViewport} from '@angular/cdk/scrolling'; | ||
| import {TaskViewService} from '../../service/task-view.service'; | ||
| import {LoggerService} from '../../../../logger/services/logger.service'; | ||
| import {NAE_TAB_DATA} from '../../../../tabs/tab-data-injection-token/tab-data-injection-token'; | ||
| import {InjectedTabData} from '../../../../tabs/interfaces'; | ||
| import {ActivatedRoute} from '@angular/router'; | ||
| import {AbstractDefaultTaskListComponent} from '../default-task-panel-list/abstract-default-task-list.component'; | ||
| import {Observable} from 'rxjs'; | ||
| import {TaskPanelData} from '../../../../panel/task-panel-data/task-panel-data'; | ||
|
|
||
| @Component({ | ||
| selector: 'ncc-abstract-task-list', | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| import {TaskPanelData} from '../../../panel/task-panel-data/task-panel-data'; | ||
| import {PageLoadRequestContext} from '../../abstract/page-load-request-context'; | ||
|
|
||
| /** | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,7 +21,7 @@ import {createMockTask} from '../../../utility/tests/utility/create-mock-task'; | |
| import {ElementaryPredicate} from '../../../search/models/predicate/elementary-predicate'; | ||
| import {Query} from '../../../search/models/query/query'; | ||
| import {Page} from '../../../resources/interface/page'; | ||
| import {TaskPanelData} from '../../../panel/task-panel-data/task-panel-data'; | ||
| import {SnackBarModule} from '../../../snack-bar/snack-bar.module'; | ||
| import {MockAuthenticationMethodService} from '../../../utility/tests/mocks/mock-authentication-method-service'; | ||
| import {NAE_BASE_FILTER} from '../../../search/models/base-filter-injection-token'; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| import {Inject, Injectable, OnDestroy, Optional} from '@angular/core'; | ||
| import {BehaviorSubject, Observable, of, ReplaySubject, Subject, Subscription, timer} from 'rxjs'; | ||
| import {TaskPanelData} from '../../../panel/task-panel-data/task-panel-data'; | ||
| import {TaskResourceService} from '../../../resources/engine-endpoint/task-resource.service'; | ||
| import {UserService} from '../../../user/services/user.service'; | ||
| import {SnackBarService} from '../../../snack-bar/services/snack-bar.service'; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -19,13 +19,31 @@ import { | |||||||||||||||||||||||||||||||||||||||||||||||||
| TaskRequestStateService, | ||||||||||||||||||||||||||||||||||||||||||||||||||
| TaskViewService, | ||||||||||||||||||||||||||||||||||||||||||||||||||
| ViewIdService, | ||||||||||||||||||||||||||||||||||||||||||||||||||
| TaskSearchRequestBody, | ||||||||||||||||||||||||||||||||||||||||||||||||||
| DataGroup, | ||||||||||||||||||||||||||||||||||||||||||||||||||
| extractFieldValueFromData, | ||||||||||||||||||||||||||||||||||||||||||||||||||
| SimpleFilter, | ||||||||||||||||||||||||||||||||||||||||||||||||||
| FilterType, | ||||||||||||||||||||||||||||||||||||||||||||||||||
| MergeOperator | ||||||||||||||||||||||||||||||||||||||||||||||||||
| } from '@netgrif/components-core'; | ||||||||||||||||||||||||||||||||||||||||||||||||||
| import {AsyncPipe} from "@angular/common"; | ||||||||||||||||||||||||||||||||||||||||||||||||||
| import { | ||||||||||||||||||||||||||||||||||||||||||||||||||
| InjectedTabbedTaskViewDataWithNavigationItemTaskData | ||||||||||||||||||||||||||||||||||||||||||||||||||
| } from "../../model/injected-tabbed-task-view-data-with-navigation-item-task-data"; | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||
| function baseFilterFactory(injectedTabData: InjectedTabbedTaskViewDataWithNavigationItemTaskData) { | ||||||||||||||||||||||||||||||||||||||||||||||||||
| const requestBody = injectedTabData.baseFilter.getRequestBody() as TaskSearchRequestBody | ||||||||||||||||||||||||||||||||||||||||||||||||||
| if (requestBody.transitionId === undefined) { | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+35
to
+36
There was a problem hiding this comment. Guard against null/undefined requestBody before property access. The type assertion on line 35 doesn't guarantee that Apply this diff to add a null check: function baseFilterFactory(injectedTabData: InjectedTabbedTaskViewDataWithNavigationItemTaskData) {
- const requestBody = injectedTabData.baseFilter.getRequestBody() as TaskSearchRequestBody
- if (requestBody.transitionId === undefined) {
+ const requestBody = injectedTabData.baseFilter.getRequestBody() as TaskSearchRequestBody;
+ if (requestBody && requestBody.transitionId === undefined) {
const viewDataGroups: Array<DataGroup> = injectedTabData.navigationItemTaskData?.slice(4, injectedTabData.navigationItemTaskData.length);🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||||||||||||||||
| const viewDataGroups: Array<DataGroup> = injectedTabData.navigationItemTaskData?.slice(4, injectedTabData.navigationItemTaskData.length); | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
There was a problem hiding this comment. 🛠️ Refactor suggestion | 🟠 Major Explain or extract the magic number 4 and simplify slice usage. The hardcoded index Additionally, Consider applying this diff: + // First 4 data groups contain [specific purpose - add comment explaining why],
+ // remaining groups contain the transition_id field
- const viewDataGroups: Array<DataGroup> = injectedTabData.navigationItemTaskData?.slice(4, injectedTabData.navigationItemTaskData.length);
+ const VIEW_DATA_START_INDEX = 4;
+ const viewDataGroups: Array<DataGroup> = injectedTabData.navigationItemTaskData?.slice(VIEW_DATA_START_INDEX);📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||||||||||||||||
| if (viewDataGroups !== undefined) { | ||||||||||||||||||||||||||||||||||||||||||||||||||
| const viewTransitionId = extractFieldValueFromData<string>(viewDataGroups, "transition_id"); | ||||||||||||||||||||||||||||||||||||||||||||||||||
| if (viewTransitionId !== undefined) { | ||||||||||||||||||||||||||||||||||||||||||||||||||
| return { | ||||||||||||||||||||||||||||||||||||||||||||||||||
| filter: injectedTabData.baseFilter.merge(new SimpleFilter('', FilterType.TASK, {transitionId: viewTransitionId?.split(",")}), MergeOperator.AND) | ||||||||||||||||||||||||||||||||||||||||||||||||||
| }; | ||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+39
to
+44
There was a problem hiding this comment. Wrap field extraction in error handling to prevent runtime exceptions.
Apply this diff to handle missing fields gracefully: if (viewDataGroups !== undefined) {
- const viewTransitionId = extractFieldValueFromData<string>(viewDataGroups, "transition_id");
- if (viewTransitionId !== undefined) {
+ try {
+ const viewTransitionId = extractFieldValueFromData<string>(viewDataGroups, "transition_id");
+ if (viewTransitionId !== undefined && viewTransitionId !== '') {
+ return {
+ filter: injectedTabData.baseFilter.merge(new SimpleFilter('', FilterType.TASK, {transitionId: viewTransitionId.split(",")}), MergeOperator.AND)
+ };
+ }
+ } catch (error) {
+ // Field not found, fallback to base filter
+ }
+ }
+ }
+ return {
+ filter: injectedTabData.baseFilter
+ };
+}Note: Also removed the redundant optional chaining ( 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||
| return { | ||||||||||||||||||||||||||||||||||||||||||||||||||
| filter: injectedTabData.baseFilter | ||||||||||||||||||||||||||||||||||||||||||||||||||
| }; | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it is not the code of the author, and this is only for future reference: attribute name
_subdoes not express what is the purpose of this attribute. I searched up, that this attribute is a subscription ofchangedFields, so something like_changedFieldSubwould me better.