Conversation
Replace occurrences of ProviderConf with LegacyProviderConf for older providers in configuration. The YmcsConf struct is renamed to ProviderConf, which now represents the new YMCS version introduced in Falconieri.
There was a problem hiding this comment.
Pull request overview
Adds a new GRAPE (Gigaset Redirect and Provisioning Environment) provider to Falconieri, including a dedicated Go client library and the necessary configuration/docs/deployment updates so GRAPE can be configured similarly to YMCS.
Changes:
- Added
grapeprovider dispatch + provider implementation wired to a newlibs/grapeHawk-auth client. - Extended configuration schema + env var parsing + Ansible templates/defaults to support GRAPE settings.
- Updated README and added a GRAPE API manual to document configuration and usage.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| providers/grape.go | New provider wrapper using a singleton GRAPE client and RegisterDevice. |
| methods/providerDispatch.go | Routes /grape/... requests to the new GRAPE provider. |
| libs/grape/auth.go | Implements Hawk request signing and request execution for GRAPE. |
| libs/grape/client.go | Defines GRAPE client structure, HTTP client, MAC normalization. |
| libs/grape/devices.go | Implements device registration + cached API discovery (settings/endpoints). |
| libs/grape/errors.go | Introduces structured API error parsing/helpers. |
| libs/grape/types.go | Adds GRAPE API response/request types. |
| libs/grape/API_MANUAL.md | Adds a technical manual for the GRAPE client library. |
| configuration/config.go | Refactors provider config structs and adds GRAPE env/config parsing. |
| deploy/ansible/roles/falconieri/templates/conf.json.tpl | Adds GRAPE provider section to generated JSON config. |
| deploy/ansible/roles/falconieri/defaults/main.yml | Adds GRAPE Ansible defaults. |
| README.md | Documents GRAPE as a supported provider + config/env vars examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
@codex[agent] open a new pull request to apply changes based on the comments in this thread |
Member
Author
|
@claude[agent] open a new pull request to apply changes based on the comments in this thread |
Implement device registration functionality for the Gigaset Redirect and Provisioning Environment (GRAPE) provisioning client library with proper MAC address normalization and caching of provisioning server identifiers. Include comprehensive error handling with structured API error types and response parsing utilities. - Add RegisterDevice method with provisioning server integration - Implement caching for provisioning server IDs and endpoints URLs - Define structured types for Grape API responses and device data - Add error type with detailed HTTP status reporting capabilities
Introduce new GRAPE provider support in system configuration and dispatch logic.
Add Grape provider to the list of supported providers and document its configuration options for both JSON and environment variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the Gigaset Redirect and Provisioning Environment (GRAPE) as a new provider in the Falconieri project. It introduces a new Go client library for GRAPE, updates configuration structures and templates, and enhances documentation to reflect the new provider. The changes ensure that GRAPE can be configured similarly to the existing YMCS provider, including support for Hawk authentication.
GRAPE provider integration:
README.mdto describe configuration parameters, environment variables, and provide example JSON configuration. [1] [2] [3] [4]grape_base_url,grape_client_id, etc.). [1] [2]Configuration and code structure:
configuration/config.goto addGrapeas a new provider and to distinguish between legacy and modern providers, updating environment variable parsing logic for GRAPE. [1] [2] [3]GRAPE client implementation:
libs/grape/) implementing the GRAPE API client, including support for Hawk authentication (auth.go), client initialization and MAC normalization (client.go), device registration logic (devices.go), error handling (errors.go), and API types (types.go). [1] [2] [3] [4] [5]These changes collectively enable Falconieri to provision devices using the Gigaset GRAPE API with secure authentication and configuration management.
NethServer/dev#7764