chore: Running 'go mod download' should catch any inconsistencies in checksums #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…checksums Running 'go mod tidy' should not be necessary as 'go mod download' should check the downloads against the 'go.sum' checksums
There was a problem hiding this comment.
Pull Request Overview
This PR removes the explicit "go mod tidy" check from the CI workflow and relies on "go mod download" to catch any inconsistencies in dependency checksums.
- Removed the go mod tidy step that checked for changes in go.mod and go.sum.
- Retained the installation of Go dependencies via go mod download.
KimNorgaard
approved these changes
Apr 25, 2025
Contributor
KimNorgaard
left a comment
KimNorgaard
left a comment
There was a problem hiding this comment.
I was just about to do this as the false negatives in CI were driving me insane :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running 'go mod tidy' should not be necessary as 'go mod download' should check the downloads against the 'go.sum' checksums