Skip to content

fix(flat-server-api): fix email language error#1986

Merged
syt-honey merged 2 commits intonetless-io:mainfrom
syt-honey:email-language
Aug 7, 2023
Merged

fix(flat-server-api): fix email language error#1986
syt-honey merged 2 commits intonetless-io:mainfrom
syt-honey:email-language

Conversation

@syt-honey
Copy link
Copy Markdown
Member

I wonder if phone numbers also need to be differentiated by language? @Leooeloel

@hyrious
Copy link
Copy Markdown
Contributor

hyrious commented Aug 7, 2023

I wonder if phone numbers also need to be differentiated by language?

I guess no. The server has set different template for different country codes https://github.com/netless-io/flat-server/blob/main/config/test.yaml#L113 (although it can only tell the prefix).

@syt-honey
Copy link
Copy Markdown
Member Author

I wonder if phone numbers also need to be differentiated by language?

I guess no. The server has set different template for different country codes https://github.com/netless-io/flat-server/blob/main/config/test.yaml#L113 (although it can only tell the prefix).

OK, you are right

@syt-honey syt-honey requested a review from hyrious August 7, 2023 09:01
Comment thread packages/flat-server-api/src/login.ts Outdated
@syt-honey syt-honey merged commit 0a258ae into netless-io:main Aug 7, 2023
@syt-honey syt-honey deleted the email-language branch August 7, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants