Skip to content

Conversation

@tzmanics
Copy link
Contributor

@tzmanics tzmanics commented Jun 8, 2022

closes #8

@tzmanics tzmanics self-assigned this Jun 8, 2022
@tzmanics tzmanics force-pushed the tzm/add-cypress branch 2 times, most recently from e56e795 to bbdf66f Compare June 8, 2022 03:36
@tzmanics tzmanics changed the title chore: adds cypress plugin and testing chore (#8): adds maintenance tooling Jun 9, 2022
@tzmanics tzmanics marked this pull request as ready for review June 9, 2022 17:28
README.md Outdated
- [Included Default Testing](#included-default-testing)
- [Removing Renovate](#removing-renovate)
- [Removing Cypress](#removing-cypress)
- [Angular 💙 Netlify Resources](#angular--netlify-resources)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want we could keep emojis in the display text of the table of contents but leave the headings the way they are now to make things map correctly.

Right now everything except this line Angular 💙 Netlify Resources works both on VSCode and GitHub because VSCode creates a heading link as #angular-💙-netlify-resources vs. GitHub makes #angular--netlify-resources.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't particularly like how it looked in the TOC but i'm open to whatever you and @taty2010 think. i can also take the 💙 out to make sure we're consistent with the naming links.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am down with whatever works best, I personally felt that the emojis in each header made it easier to separate out each section when scrolling through the README but now that we are adding the TOC I think we can live without them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i totally agree. i did like the visual guide to the docs 😕

Copy link
Contributor

@maxcell maxcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! All links work well and I think we're ready to ship!

I noticed there was some conflict with renovate.json but I am not certain why? 🤔 but should be good after that!

@tzmanics tzmanics merged commit 19a0e3b into main Jun 11, 2022
@tzmanics tzmanics deleted the tzm/add-cypress branch June 11, 2022 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adds maintenance tooling

4 participants