-
Notifications
You must be signed in to change notification settings - Fork 35
chore (#8): adds maintenance tooling #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e56e795 to
bbdf66f
Compare
README.md
Outdated
| - [Included Default Testing](#included-default-testing) | ||
| - [Removing Renovate](#removing-renovate) | ||
| - [Removing Cypress](#removing-cypress) | ||
| - [Angular 💙 Netlify Resources](#angular--netlify-resources) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want we could keep emojis in the display text of the table of contents but leave the headings the way they are now to make things map correctly.
Right now everything except this line Angular 💙 Netlify Resources works both on VSCode and GitHub because VSCode creates a heading link as #angular-💙-netlify-resources vs. GitHub makes #angular--netlify-resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i didn't particularly like how it looked in the TOC but i'm open to whatever you and @taty2010 think. i can also take the 💙 out to make sure we're consistent with the naming links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am down with whatever works best, I personally felt that the emojis in each header made it easier to separate out each section when scrolling through the README but now that we are adding the TOC I think we can live without them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i totally agree. i did like the visual guide to the docs 😕
maxcell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me! All links work well and I think we're ready to ship!
I noticed there was some conflict with renovate.json but I am not certain why? 🤔 but should be good after that!
closes #8