This repository was archived by the owner on Jan 25, 2023. It is now read-only.
Define NETLIFY_BUILD_NODE_VERSION and "nvm install" it#375
Merged
Conversation
Contributor
Author
|
#376 should fix the CI failure on this PR. |
ehmicky
approved these changes
Feb 28, 2020
Contributor
ehmicky
left a comment
ehmicky
left a comment
There was a problem hiding this comment.
Looks good. Just one detail: I don't think you need to do nvm use 10. When doing nvm install --no-progress 10, it automatically switches to Node 10 at the end. You might want to add a comment though to specify that the command is meant here to both install and switch version.
Benaiah
force-pushed
the
define-and-install-NETLIFY_BUILD_NODE_VERSION
branch
from
aad3dfa to
6d57b00
Compare
Contributor
Author
|
Ok, removed the extraneous |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds
--no-progressflag tonvm installcommands to clean up logs.