This repository was archived by the owner on Jan 25, 2023. It is now read-only.
Merged
Conversation
mheffner
reviewed
Apr 9, 2020
Contributor
mheffner
left a comment
mheffner
left a comment
There was a problem hiding this comment.
@aarushik93 I think there appear to be two locations we run this. The Dockerfile should only be invoked during our own Jenkins CI build of the "build image". My guess is that the output the user is seeing during their builds is coming from the second time we invoke it in the functions script:
build-image/run-build-functions.sh
Line 586 in 0e6e2bd
Contributor
Author
|
ahh updated, thanks for pointing that out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to issue 217
Clears up all the unneeded logs + runs the commands.
Leaving in 'go version', because original script doesn't have it in qutoes, meaning the command as well as output shows up.