You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jan 25, 2023. It is now read-only.
Could we stop referencing the latest tag in our CI instead and explicitly reference xenial? I always felt latest was somewhat a misnomer, so referencing directly by the branch/version we want might be clearer? 🤷
@mheffner in the buildbot we reference a specific tagged release, not latest. The problem with not keeping latest up to date is that it's the default tag used by the docker CLI if you don't specify a tag. This leads to people running docker pull netlify/build and getting an image that was significantly out of date. We've had multiple users run into this in the past.
@vbrown608 I tried doing this myself, but I was trying to get the latest tagged release to get pushed to latest, and couldn't find a good way to do that (there's buildingTag(), but how do you tell if it's the latest tag being built?). Basing it on the xenial branch means people will sometimes get changes that have been merged but not released, but since I couldn't find a good alternative this seems to be the best solution.
@Benaiah That's fair, I noticed the README mentions the explicit tags even. Can we update the test-build.sh script to use the xenial tag though? It looks like it's defaulting to latest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
type: chorework needed to keep the product and development running smoothly
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vbrown608
added
the
type: chore
For now, xenial represents our most up-to-date build image. We should follow Docker conventions and tag it as latest.
Application of the
latesttag is based on https://www.jenkins.io/doc/book/pipeline/docker/. I'm not a jenkins expert so feedback is welcome!