This repository was archived by the owner on Jan 25, 2023. It is now read-only.
Conversation
mheffner
reviewed
Jun 17, 2020
Contributor
mheffner
left a comment
mheffner
left a comment
There was a problem hiding this comment.
Do we need to do the gem bundle install for that version as well?
Contributor
Author
|
That's a good point. Buildbot will install Bundler if it's missing (and it installs a lot faster than Ruby) but I think it makes sense to go ahead and preinstall it if we're preinstalling the Ruby version 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many users are still pinned to Ruby 2.6.2, and are seeing an error like
Although we're defaulting to 2.7 for new sites, we should continue to preinstall 2.6.2 or most users builds will be slowed down by about 15 seconds, regardless of whether they're using Ruby.