Skip to content

Conversation

@taty2010
Copy link
Contributor

@taty2010 taty2010 commented Feb 2, 2023

🎉 Thanks for submitting a pull request! 🎉

Summary

Updated the getFrameworkById function to be exported. This will give us the option to pull up-to-date information on each framework in areas where the framework has already been determined but still require the information provided within framework-info.

Fixes https://github.com/netlify/pod-ecosystem-frameworks/issues/383


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

wurd8d4j80541

@taty2010 taty2010 self-assigned this Feb 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files. Consider converting them to TypeScript.
Thank you for converting JavaScript files to TypeScript 🎉"

@taty2010 taty2010 requested a review from MarcL February 2, 2023 21:44
@nickytonline nickytonline requested review from orinokai and sarahetter and removed request for MarcL February 3, 2023 13:36
@danez
Copy link
Contributor

danez commented Feb 3, 2023

Sorry I just created some conflicts for this PR, because frameworks-info is now fully migrated to TS. :) But shouldn't be super hard to resolve. If I can help somehow let me know.

@kodiakhq kodiakhq bot merged commit ff37e4c into main Feb 3, 2023
@kodiakhq kodiakhq bot deleted the tn/export-getframeworkById branch February 3, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants