fix: respect manual order of frameworks #4858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a regression of #4819
Contributor
|
This pull request adds or modifies JavaScript ( |
danez
commented
Feb 9, 2023
| "name": "vuepress", | ||
| "version": "4.5.6", | ||
| "name": "@vue/cli-service", | ||
| "version": "1.2.3", |
Contributor
Author
There was a problem hiding this comment.
This is an example of what was wrong, vuepress, should be returned first, before vue.
lukasholzer
approved these changes
Feb 9, 2023
danez
commented
Feb 9, 2023
| "build:browser": "run-s build:browser:*", | ||
| "build:browser:core": "vite build", | ||
| "build:browser:site-root": "cpy index.html ./dist", | ||
| "pretest": "run-s prebuild", |
Contributor
Author
There was a problem hiding this comment.
when running npm test locally ensure that the generated files are up2date. We do not need to run the whole build before the test, but only the file generation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression of #4819
In the migration to TS I missed that the frameworks return by list() have a specific order. The order is defined in the variable
FRAMEWORK_NAMES.So instead of using glob() to find a all json files I reverted to used the
FRAMEWORK_NAMESlist.For this I had to rearrange some stuff, because in the JavaScript file that generates the list of frameworks we cannot import TypeScript files.
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)