Skip to content

Conversation

@mrstork
Copy link
Contributor

@mrstork mrstork commented May 23, 2025

Summary

Now that we use node >18 we can drop the node-fetch polyfill from the package
Part of FRB-1833


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

"read-pkg": "^9.0.0",
"semver": "^7.3.8",
"yaml": "^2.1.3",
"yaml": "^2.8.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change, just matching the version to what's in the package-lock already.
See #6332

@mrstork mrstork marked this pull request as ready for review May 23, 2025 14:43
@mrstork mrstork requested a review from a team as a code owner May 23, 2025 14:43
@mrstork mrstork merged commit ed08b0d into main May 23, 2025
33 checks passed
@mrstork mrstork deleted the build-info-drop-fetch branch May 23, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants