Skip to content

Conversation

@eduardoboucas
Copy link
Member

Summary

Adds a quiet flag that reduces the output of Netlify Build to a minimum, showing just essential information, errors, and user-generated output.

This is particularly useful for the startDev entry point used by the CLI. Currently, the full Netlify Build information screen is printed on netlify dev, which feels bloated and unnecessary. By making use of the new flag, we'll be able to reduce the output to the essential information.

Before:

Screenshot 2022-12-21 at 20 31 52

After:

Screenshot 2022-12-21 at 20 30 26

@eduardoboucas eduardoboucas added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Dec 21, 2022
@github-actions
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@eduardoboucas eduardoboucas marked this pull request as ready for review December 21, 2022 20:40
@eduardoboucas eduardoboucas requested a review from a team December 21, 2022 23:48
Copy link
Contributor

@lukasholzer lukasholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about making the quiet the default and instead having a --verbose flag?

@eduardoboucas
Copy link
Member Author

What do you think about making the quiet the default and instead having a --verbose flag?

Interestingly, we already have a --verbose flag (#3934), which seems to be equivalent to --debug.

I agree that this is not ideal, and we should probably have a single flag that allowed you to specify different levels of verbosity. That is a deeper change that I didn't feel comfortable making, to be honest.

As for whether the quiet mode should be the default, I'm not sure I agree. I was planning on using this just on the startDev entry point (which is only used in Netlify Dev). When you're running a full build, I think the current information we print is useful, and if we feel that it isn't I think we should have a wider conversation to identify exactly what we want to show there.

Copy link
Contributor

@lukasholzer lukasholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kodiakhq kodiakhq bot merged commit c58f966 into main Dec 22, 2022
@kodiakhq kodiakhq bot deleted the feat/quiet branch December 22, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Adds or modifies js files automerge type: feature code contributing to the implementation of a feature and/or user facing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants