Skip to content

Conversation

@JakeChampion
Copy link
Contributor

@JakeChampion JakeChampion commented Apr 9, 2025

read-package-up was a breaking change from read-pkg-up, the breaking change was requiring node 18

sindresorhus/read-package-up@v10.1.0...v11.0.0

same for archiver v6 and above, and get-stream v7 and above

@JakeChampion JakeChampion requested a review from a team as a code owner April 9, 2025 13:30
@JakeChampion JakeChampion force-pushed the jake/fix branch 9 times, most recently from aba6b44 to 85e09f9 Compare April 9, 2025 18:58
read-package-up was a breaking change from read-pkg-up, the breaking change was requiring node 18

sindresorhus/read-package-up@v10.1.0...v11.0.0
"@netlify/serverless-functions-api": "^1.36.0",
"@vercel/nft": "0.27.7",
"archiver": "^7.0.0",
"archiver": "^5.3.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newer versions dropped support for node 14

"decompress": "4.2.1",
"deepmerge": "^4.3.1",
"get-stream": "8.0.1",
"get-stream": "6.0.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newer versions dropped support for node 14

"@opentelemetry/core": "~1.24.0",
"@opentelemetry/resources": "~1.24.0",
"@opentelemetry/semantic-conventions": "~1.24.0",
"read-pkg-up": "^9",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newer versions dropped support for node 14

"pretty-ms": "^8.0.0",
"ps-list": "^8.0.0",
"read-package-up": "^11.0.0",
"read-pkg-up": "^9.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newer versions dropped support for node 14

@JakeChampion JakeChampion changed the title fix: swap from read-package-up to read-pkg-up fix: update dependency versions to ones which support node 14 Apr 9, 2025
Copy link
Member

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's weird that none of these were causing problems as far as we know.

and parse-imports requiring node 18 is still in here? 🤔 https://github.com/netlify/build/blob/5cc67e64416572d66de73b9ba112b105509448ce/package-lock.json#L25613-L25625

"common-path-prefix": "^3.0.0",
"env-paths": "^3.0.0",
"esbuild": "0.21.2",
"esbuild": "0.25.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️ I'm going to just trust you on this change?

@serhalp
Copy link
Member

serhalp commented Apr 9, 2025

Love the dependency tree shrinking btw! This is going to be nice in netlify-cli.

@JakeChampion JakeChampion enabled auto-merge (squash) April 9, 2025 20:47
@JakeChampion JakeChampion merged commit b6fa012 into main Apr 9, 2025
34 checks passed
@JakeChampion JakeChampion deleted the jake/fix branch April 9, 2025 21:56
This was referenced Sep 2, 2025
This was referenced Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants