-
Notifications
You must be signed in to change notification settings - Fork 82
fix: update dependency versions to ones which support node 14 #6189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aba6b44 to
85e09f9
Compare
read-package-up was a breaking change from read-pkg-up, the breaking change was requiring node 18 sindresorhus/read-package-up@v10.1.0...v11.0.0
| "@netlify/serverless-functions-api": "^1.36.0", | ||
| "@vercel/nft": "0.27.7", | ||
| "archiver": "^7.0.0", | ||
| "archiver": "^5.3.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newer versions dropped support for node 14
| "decompress": "4.2.1", | ||
| "deepmerge": "^4.3.1", | ||
| "get-stream": "8.0.1", | ||
| "get-stream": "6.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newer versions dropped support for node 14
| "@opentelemetry/core": "~1.24.0", | ||
| "@opentelemetry/resources": "~1.24.0", | ||
| "@opentelemetry/semantic-conventions": "~1.24.0", | ||
| "read-pkg-up": "^9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newer versions dropped support for node 14
| "pretty-ms": "^8.0.0", | ||
| "ps-list": "^8.0.0", | ||
| "read-package-up": "^11.0.0", | ||
| "read-pkg-up": "^9.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newer versions dropped support for node 14
serhalp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It's weird that none of these were causing problems as far as we know.
and parse-imports requiring node 18 is still in here? 🤔 https://github.com/netlify/build/blob/5cc67e64416572d66de73b9ba112b105509448ce/package-lock.json#L25613-L25625
| "common-path-prefix": "^3.0.0", | ||
| "env-paths": "^3.0.0", | ||
| "esbuild": "0.21.2", | ||
| "esbuild": "0.25.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👁️ I'm going to just trust you on this change?
|
Love the dependency tree shrinking btw! This is going to be nice in netlify-cli. |
read-package-up was a breaking change from read-pkg-up, the breaking change was requiring node 18
sindresorhus/read-package-up@v10.1.0...v11.0.0
same for archiver v6 and above, and get-stream v7 and above