Conversation
The `resolve` package is unmaintained. This replaces it with `oxc-resolver`, a modern, actively maintained, very fast Rust-based resolver from the oxc project, powering Rolldown and Vite. - `@netlify/build`: Use oxc-resolver and convert the file `.ts` while I'm here - `@netlify/zip-it-and-ship-it`: Use oxc-resolver with `symlinks: false` to preserve symlink paths, as previously. - Remove weird fallback to `require.resolve()` on failures, as oxc-resolver provides good error messages Fixes #6697.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Awesome! If this doesn't work out for any reason, several alternatives listed here: es-tooling/module-replacements#340 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
resolvepackage is unmaintained. This replaces it withoxc-resolver, a modern, actively maintained, very fast Rust-based resolver from the oxc project, powering Rolldown and Vite.@netlify/build: Use oxc-resolver and convert the file to.tswhile I'm here@netlify/zip-it-and-ship-it: Use oxc-resolver withsymlinks: falseto preserve symlink paths, as previously.require.resolve()on failures, as oxc-resolver provides good error messagesNote
I created this commit a month ago and forgot about it. I don't remember the status of this 😆. I'm opening this PR to not lose it again.