fix(sites-delete): use siteId instead of cwdSiteId for warning messages #1978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
Mar 10, 2021
| if (noForce) { | ||
| this.log(`${chalk.redBright('Warning')}: You are about to permanently delete "${chalk.bold(siteData.name)}"`) | ||
| this.log(` Verify this siteID "${cwdSiteId}" supplied is correct and proceed.`) | ||
| this.log(` Verify this siteID "${siteId}" supplied is correct and proceed.`) |
Contributor
Author
There was a problem hiding this comment.
cwdSiteId is taken from .netlify/state.json if exists.
siteId is the argument passed to the command
erezrokah
requested review from
JGAntunes and
ehmicky
and removed request for
JGAntunes
ehmicky
approved these changes
Mar 11, 2021
This was referenced Mar 11, 2021
Closed
Closed
Merged
This was referenced Mar 15, 2021
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
When running
ntl sites:delete <site-id>from a directory not linked to a site the prompt before deleting the site hadundefinedin the warning message.This PR fixes it.
- Test plan
Before:
After:
- Description for the changelog
Fix
undefinedin warning message when deleting a site.- A picture of a cute animal (not mandatory but encouraged)
