Skip to content

fix(sites-delete): use siteId instead of cwdSiteId for warning messages #1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2021
Merged

fix(sites-delete): use siteId instead of cwdSiteId for warning messages #1978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/commands/sites/delete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class SitesDeleteCommand extends Command {
/* Verify the user wants to delete the site */
if (noForce) {
this.log(`${chalk.redBright('Warning')}: You are about to permanently delete "${chalk.bold(siteData.name)}"`)
this.log(` Verify this siteID "${cwdSiteId}" supplied is correct and proceed.`)
this.log(` Verify this siteID "${siteId}" supplied is correct and proceed.`)
Copy link
Contributor Author

@erezrokah erezrokah Mar 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cwdSiteId is taken from .netlify/state.json if exists.
siteId is the argument passed to the command

this.log(' To skip this prompt, pass a --force flag to the delete command')
this.log()
this.log(`${chalk.bold('Be careful here. There is no undo!')}`)
Expand All @@ -66,7 +66,7 @@ class SitesDeleteCommand extends Command {
this.log(`Supplied: "${siteId}"`)
this.log(`Current Site: "${cwdSiteId}"`)
this.log()
this.log(`Verify this siteID "${cwdSiteId}" supplied is correct and proceed.`)
this.log(`Verify this siteID "${siteId}" supplied is correct and proceed.`)
this.log('To skip this prompt, pass a --force flag to the delete command')
const { wantsToDelete } = await inquirer.prompt({
type: 'confirm',
Expand Down