feat: upload zip after deploy #7573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with a873f90
|
khendrikse
reviewed
Aug 21, 2025
|
|
||
| const draft = !deployToProduction && !alias | ||
| results = await api.createSiteDeploy({ siteId, title, body: { draft, branch: alias } }) | ||
| const createDeployBody = { draft, branch: alias, include_upload_url: options.uploadSourceZip } |
Contributor
There was a problem hiding this comment.
@denar90 I think it would be good to add something here that shows a warning and then quits for windows users if they are using this new flag, since I think they are not able to use the zip functionality
Contributor
Author
There was a problem hiding this comment.
good idea, I moved on command level and default falg to false
khendrikse
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes #<replace_with_issue_number>
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)