fix: set same Node.js options locally as AWS Lambda does in production #7735
+174
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with 6a38183
|
serhalp
force-pushed
the
fix/throws-on-exports-condition-module-sync
branch
2 times, most recently
from
79f9b4a to
5930f6f
Compare
serhalp
commented
Oct 22, 2025
| NODE_OPTIONS: ['--no-experimental-require-module', '--no-experimental-detect-module'] | ||
| // Unfortunately Node.js throws if `NODE_OPTIONS` contains any unsupported flags and these flags have been added | ||
| // and removed in various specific versions in each major line. Luckily Node.js has an API just for this! | ||
| .filter((flag) => process.allowedNodeEnvironmentFlags.has(flag)) |
There was a problem hiding this comment.
It turns out that, despite these Node.js features being enabled by default on some subset of these Node.js 20 and 22 versions, AWS Lambda disables them explicitly via flags: https://docs.aws.amazon.com/lambda/latest/dg/lambda-nodejs.html#w292aac41c19.. This leads to a mismatch between the local dev Netlify Functions environment and the production (AWS Lambda) environment, leading to confusing bugs like this: netlify/react-router-template#10 (comment).
serhalp
force-pushed
the
fix/throws-on-exports-condition-module-sync
branch
from
5930f6f to
e80c5a6
Compare
pieh
approved these changes
Oct 23, 2025
pieh
reviewed
Oct 23, 2025
serhalp
force-pushed
the
fix/throws-on-exports-condition-module-sync
branch
from
82c9cd4 to
01dd0d5
Compare
serhalp
commented
Oct 23, 2025
Comment on lines
+291
to
+292
| process.allowedNodeEnvironmentFlags.has('--no-experimental-require-module') || | ||
| process.allowedNodeEnvironmentFlags.has('--experimental-require-module'), |
There was a problem hiding this comment.
This may seem weird, but it's because some node.js versions support the positive flag and some node.js versions support the negative flag
pieh
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Despite these Node.js features being enabled by default on some subset of these Node.js 20 and 22 versions, AWS Lambda always disables them explicitly via flags: https://docs.aws.amazon.com/lambda/latest/dg/lambda-nodejs.html#w292aac41c19.
This leads to a mismatch between the local dev Netlify Functions environment and the production (AWS Lambda) environment, leading to confusing bugs like this: netlify/react-router-template#10 (comment).
This PR replicates the production Netlify Functions behaviour in the local execution environment.
Following the repro steps from the React Router 7 bug above, I've confirmed this fixes it ✅.
It would be nice to add test coverage but I failed to write a failing test 😓.Woo, I did it.