feat: begin integrating @netlify/dev#7950
Conversation
package.json
Outdated
| "@netlify/db": "^0.1.0", | ||
| "@netlify/db-dev": "^0.2.0", |
There was a problem hiding this comment.
huh, test fixtures with a package.json don't get npm installed?
There was a problem hiding this comment.
Ah, I see what you mean. Moved to the fixture deps in bd20f1c.
| if (force === undefined) { | ||
| const existingValue = await store.get(key) | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition |
There was a problem hiding this comment.
Is there a wrong type we should be fixing?
There was a problem hiding this comment.
Linting started failing for this, randomly. I haven't yet had the time to understand why, since I haven't touched this part of the code.
There was a problem hiding this comment.
I'll look into this as a follow-up.
|
|
||
| injectEnvVariables(env) | ||
|
|
||
| const programmaticNetlifyDev = await startProgrammaticNetlifyDev({ |
There was a problem hiding this comment.
You may know this already, but for completeness: this would need to also be hooked up in the dev:exec, serve, and functions:serve commands.
There was a problem hiding this comment.
Yeah, I'll do that in a follow up. Having this on dev for now is fine.
Co-authored-by: Philippe Serhal <philippe.serhal@netlify.com>
* feat: begin integrating `@netlify/dev` * chore: add deps * fix(deps): bump netlify packages to dedupe with @netlify/dev * chore: update deps * chore: fix lint issue * chore: add debug logging * chore: add comment Co-authored-by: Philippe Serhal <philippe.serhal@netlify.com> * chore: cap site name length in tests * chore: update snapshot --------- Co-authored-by: Philippe Serhal <philippe.serhal@netlify.com>
2 participants
Sets the foundation for integrating
@netlify/devin the CLI. We start by disabling all features (except fordb, which is enabled with an environment variable). Then we can gradually start enabling individual features and remove the corresponding code from the codebase.As for the term "programmatic", I was looking for a way to distinguish the new
@netlify/devpackage (which offers a programmatic interface for the emulation of the Netlify platform) from the existing Netlify Dev command. Naming things is hard. Happy to go for another term if someone has a better idea.