Skip to content

fix: deploy DB migrations#8103

Merged
eduardoboucas merged 1 commit intomainfrom
fix/deploy-db-migrations
Mar 26, 2026
Merged

fix: deploy DB migrations#8103
eduardoboucas merged 1 commit intomainfrom
fix/deploy-db-migrations

Conversation

@eduardoboucas
Copy link
Member

We are generating migration files but we're not including them in the deployed files. This PR addresses that.

@eduardoboucas eduardoboucas requested a review from a team as a code owner March 26, 2026 14:15
@coderabbitai
Copy link

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b161e8a7-531f-4e27-9f55-844234a969d3

📥 Commits

Reviewing files that changed from the base of the PR and between 3c5c76f and 4ab3c46.

📒 Files selected for processing (3)
  • src/utils/deploy/deploy-site.ts
  • src/utils/deploy/process-files.ts
  • tests/integration/commands/deploy/deploy.test.ts

📝 Walkthrough

Summary by CodeRabbit

Release Notes

  • New Features

    • Database migrations are now automatically included in site deployments and tracked in deployment checksums.
  • Tests

    • Added integration tests validating deployment behavior with and without database migrations.

Walkthrough

This change introduces support for database migrations in the deployment process. The deploySite function now includes an optional DB migrations directory in the file hash calculation. A new helper function getDbMigrationsDistPathIfExists checks for the existence of the migrations directory and returns its path if present. The deployFileNormalizer is extended with logic to rewrite normalized paths for migration files to use a designated public URL path. Integration tests verify that migrations are correctly included in deployment requests when present and excluded when absent.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: deploy DB migrations' clearly and concisely describes the main change: addressing the deployment of database migration files.
Description check ✅ Passed The description directly relates to the changeset by explaining the problem (migration files not included) and solution (this PR addresses that).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/deploy-db-migrations

Comment @coderabbitai help to get the list of available commands and usage tips.

@eduardoboucas eduardoboucas enabled auto-merge (squash) March 26, 2026 14:16
@github-actions
Copy link

📊 Benchmark results

Comparing with 3c5c76f

  • Dependency count: 1,059 (no change)
  • Package size: 354 MB ⬆️ 0.00% increase vs. 3c5c76f
  • Number of ts-expect-error directives: 356 (no change)

@eduardoboucas eduardoboucas merged commit 8d7c0a5 into main Mar 26, 2026
71 checks passed
@eduardoboucas eduardoboucas deleted the fix/deploy-db-migrations branch March 26, 2026 14:34
eduardoboucas pushed a commit that referenced this pull request Mar 26, 2026
🤖 I have created a release *beep* *boop*
---


## [24.6.2](v24.6.1...v24.6.2)
(2026-03-26)


### Bug Fixes

* deploy DB migrations
([#8103](#8103))
([8d7c0a5](8d7c0a5))
* **deps:** update dependency fastify to v5.8.3 [security]
([#8096](#8096))
([d3a3059](d3a3059))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants