Skip to content

fix: improve reliability of anon deploys#8170

Merged
sean-roberts merged 2 commits intomainfrom
sr/fix-deploy-tests
Apr 21, 2026
Merged

fix: improve reliability of anon deploys#8170
sean-roberts merged 2 commits intomainfrom
sr/fix-deploy-tests

Conversation

@sean-roberts
Copy link
Copy Markdown
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

don't do actual anon deploys as those are limited by IP per day causing reliability issues for testing


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@sean-roberts sean-roberts requested a review from a team as a code owner April 17, 2026 18:26
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 70d91e0e-533c-472e-bf04-efb38050b5a7

📥 Commits

Reviewing files that changed from the base of the PR and between 7da602c and a5533ad.

📒 Files selected for processing (1)
  • tests/integration/commands/deploy/deploy-anonymous.test.ts

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Refactored test infrastructure for unauthenticated deployment scenarios with improved helper utilities for CLI configuration.

Walkthrough

This change introduces a local helper function getUnauthenticatedCLIOptions in a test file to standardize CLI execution options for unauthenticated scenarios. The helper encapsulates configuration of environment variables including NETLIFY_API_URL, NETLIFY_AUTH_TOKEN, and NETLIFY_SITE_ID, with controlled environment setup. Multiple inline CLI option constructions throughout the test file are replaced with calls to this centralized helper, reducing duplication and improving maintainability of the test setup logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: refactoring anonymous deploy tests to avoid actual anonymous deploys, which improves test reliability by circumventing IP-rate-limit issues.
Description check ✅ Passed The description clearly explains the motivation for the change: avoiding actual anonymous deploys in tests because they are limited by IP per day, causing reliability issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sr/fix-deploy-tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 17, 2026

📊 Benchmark results

Comparing with e89048e

  • Dependency count: 1,061 (no change)
  • Package size: 355 MB (no change)
  • Number of ts-expect-error directives: 356 (no change)

@sean-roberts sean-roberts enabled auto-merge (squash) April 21, 2026 14:47
@sean-roberts sean-roberts merged commit 95b5e52 into main Apr 21, 2026
69 checks passed
@sean-roberts sean-roberts deleted the sr/fix-deploy-tests branch April 21, 2026 15:08
sean-roberts pushed a commit that referenced this pull request Apr 22, 2026
🤖 I have created a release *beep* *boop*
---


## [25.2.0](v25.1.1...v25.2.0)
(2026-04-22)


### Features

* use database as primary name for new db subcommands
([#8176](#8176))
([40e56cf](40e56cf))


### Bug Fixes

* don't cause fatal issues when doing update checks inside of agent
sandbox ([#8186](#8186))
([acaf478](acaf478))
* filter out intentional user-input errors from error-reporting-lamda
([#8188](#8188))
([b5b60e3](b5b60e3))
* improve reliability of anon deploys
([#8170](#8170))
([95b5e52](95b5e52))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants