Skip to content

fix(deps): remove uuid dependency#8275

Merged
khendrikse merged 3 commits into
netlify:mainfrom
gameroman:uuid
May 29, 2026
Merged

fix(deps): remove uuid dependency#8275
khendrikse merged 3 commits into
netlify:mainfrom
gameroman:uuid

Conversation

@gameroman
Copy link
Copy Markdown
Contributor

No description provided.

@gameroman gameroman requested a review from a team as a code owner May 27, 2026 20:38
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • Refactor
    • Removed the uuid external package dependency. Migrated UUID generation to Node.js's built-in crypto.randomUUID() throughout the application, including blobs server authentication, live-tunnel client identification, test directory creation, and deployment test utilities. This reduces external dependencies while maintaining full functionality and performance.

Walkthrough

This pull request removes the uuid dependency from package.json and replaces all uses of the uuid package with Node.js's built-in crypto.randomUUID() across runtime code (src/lib/blobs/blobs.ts, src/utils/live-tunnel.ts) and tests (tests/integration/utils/site-builder.ts, tests/unit/utils/deploy/upload-files.test.ts). Imports were updated accordingly and UUID generation calls were switched to use crypto.randomUUID() (sliced where previously truncated).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, but the title alone is sufficiently clear about the change. Consider adding a brief description explaining why uuid was removed and how crypto.randomUUID() provides equivalent functionality without external dependencies.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing the uuid package dependency and replacing it with Node's built-in crypto.randomUUID().
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Linked repositories: Couldn't analyze netlify/blueprints - clone failed: Clone operation failed: Cloning into '/home/jailuser/git'...
warning: templates not found in /usr/share/git-core/templates
fatal: unable to access 'https://github.com/netlify/blueprints.git/': Failed to connect to github.com port 443 after 134599 ms: Couldn't connect to server


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@serhalp serhalp changed the title chore: remove uuid dependency fix(deps): remove uuid dependency May 28, 2026
Copy link
Copy Markdown
Member

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo, thank you friend!

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
package.json (1)

57-155: ⚠️ Potential issue | 🟠 Major

Regenerate package-lock.json to fully remove uuid

  • package.json no longer declares uuid (and no uuid imports/uses were found in TS/JS sources).
  • package-lock.json still includes uuid (e.g., packages[""].dependencies.uuid plus dist/bin/uuid / dist-node/bin/uuid entries), so the lockfile wasn’t fully regenerated—update it so uuid is dropped from the install tree.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` around lines 57 - 155, The lockfile still contains the uuid
package even though package.json no longer lists it; delete package-lock.json
and node_modules (or run a full lockfile refresh), then regenerate the lockfile
by running a clean install (e.g., npm install or npm ci) so the install tree no
longer includes packages[""].dependencies.uuid and the dist/bin/uuid or
dist-node/bin/uuid entries; verify uuid is absent from the regenerated
package-lock.json, run the test/build to ensure nothing breaks, and commit the
updated package-lock.json.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@package.json`:
- Around line 57-155: The lockfile still contains the uuid package even though
package.json no longer lists it; delete package-lock.json and node_modules (or
run a full lockfile refresh), then regenerate the lockfile by running a clean
install (e.g., npm install or npm ci) so the install tree no longer includes
packages[""].dependencies.uuid and the dist/bin/uuid or dist-node/bin/uuid
entries; verify uuid is absent from the regenerated package-lock.json, run the
test/build to ensure nothing breaks, and commit the updated package-lock.json.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b6a9368b-7dfa-47d9-a16d-d7bd8d4030cc

📥 Commits

Reviewing files that changed from the base of the PR and between 52a109d and ee95f95.

📒 Files selected for processing (1)
  • package.json

@khendrikse khendrikse merged commit 4f2a96b into netlify:main May 29, 2026
52 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants