fix(command-dev): handle headers with colon in value #1855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
Feb 8, 2021
| } | ||
|
|
||
| if (line.includes(':')) { | ||
| const [key = '', value = ''] = line.split(':', 2) |
Contributor
Author
There was a problem hiding this comment.
This is a port of our Ruby code. TIL limit in Ruby's split doesn't mean the same thing as limit in JavaScript's split.
erezrokah
force-pushed
the
fix/headers_parsing
branch
from
e8e8cdf to
57da0aa
Compare
eduardoboucas
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #1777 to fix header values such as
https://www.example.com