fix(command-dev): pass dev context to '@netlify/config' #1878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
Feb 14, 2021
| await builder.buildAsync() | ||
|
|
||
| await withDevServer({ cwd: builder.directory, env: { CONTEXT: 'production' }, args }, async (server) => { | ||
| await withDevServer({ cwd: builder.directory, args }, async (server) => { |
Contributor
Author
There was a problem hiding this comment.
I think we should allow overriding it via process level env, but can go either way
erezrokah
added
type: chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Fixes #1873
- Test plan
Added a couple of tests
- Description for the changelog
Pass
context: devto@netlify/configwhen running dev related commands. This should tell@netlify/configto resolve settings from the correctcontext.- A picture of a cute animal (not mandatory but encouraged)
