refactor: enable and fix fp/no-loops

[tinfoil-knight]

- Summary

See #1891

Enables the fp/no-loops for eslint-plugin-fp.

• for loops were changed to use forEach or other array methods like map, some or every wherever appropriate.
• Retry logic was changed from using loop to being recursive in nature.
• 4 instances of for loop were ignored due to any of the following reasons:
  • async/await doesn't work with forEach
  • recursive solutions would be functional but hard to read/understand
  • Promise.allSettled is not supported below 12.9.0 (Can replace making await() requests in for loops)

- Test plan

• npx ava --serial --verbose ran without any errors.

[tinfoil-knight]

All failing tests have been fixed.

[tinfoil-knight]

It seems that the ?. operator isn't supported yet for node in the CI. Will need to change it.

@erezrokah What version of node is the CI supporting for tests?

Also, I received a ESLint warning when using Promise.allSettled which is incompatible with current node engine specified but didn't get one for using the optional chaining operator which is only supported for >=14.0.0.

[tinfoil-knight]

@erezrokah All tests are passing for the CI except on ubuntu-latest, bash, 10.x.

The error seems to be in the detect-server.js file. I can't reproduce the issue but I'll try pushing a fix.

[erezrokah]

@erezrokah What version of node is the CI supporting for tests?

The CLI supports Node.js >= 10.18.0, The optional chaining operator ?. is supported for Node.js >= 14

[erezrokah]

The error seems to be in the detect-server.js file. I can't reproduce the issue but I'll try pushing a fix.

You can use nvm to install and switch to Node.js 10 locally.

[erezrokah]

I've added a few more comments.

In general we should treat fp/no-loops as a guideline and not a strict rule, as sometimes it's better to have a for loop.

[tinfoil-knight]

@erezrokah I've made all the requested changes and tested on Node.js 10 w/ npx ava -v -s

[erezrokah]

🚀

[tinfoil-knight]

Thank you @erezrokah for merging my first PR in this repository. More PRs upcoming!

[erezrokah]

Great work @tinfoil-knight, looking forward 👍