refactor: enable and fix fp/no-proxy #2931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
added
the
type: chore
erezrokah
approved these changes
Jul 14, 2021
There was a problem hiding this comment.
Thanks @tinfoil-knight nice catch. I got an error on a missing ctor with the previous code.
Looks like we should use https://github.com/chalk/chalk/tree/v4.1.1#chalklevel
The examples on the default branch are already updated for the switch to ESM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
See #1891
Enables the fp/no-proxy for
eslint-plugin-fp.There was only a single instance of Proxy being used to disable colors for the chalk package. The package now has a
leveloption that can be used to disable the coloring as documented here: https://github.com/chalk/chalk#chalklevel.The file:
src/utils/command.jswas using this custom chalk instance.- Test plan
npx ava -v -sran without errors. I tried out thesites:listcommand normally and with the--jsonflag. As expected--jsonproduced discolored output.