Skip to content

Conversation

@jasonbarry
Copy link
Contributor

@jasonbarry jasonbarry commented Oct 7, 2022

Summary

This PR changes the post-processing flag from snake_case to kebab-case to match the convention of deploy context values (e.g. branch-deploy and deploy-preview). Our API supports both snake and kebab, but moving them to kebab in our CLI will make them more consistent when showing help commands like netlify env:list --help.

Changes to open-api forthcoming.

https://github.com/netlify/pillar-workflow/issues/808


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Oct 7, 2022
@jasonbarry jasonbarry self-assigned this Oct 7, 2022
@github-actions
Copy link

github-actions bot commented Oct 7, 2022

📊 Benchmark results

Comparing with 791a398

Package size: 241 MB

(no change)

^  241 MB  241 MB 
│   ┌──┐    ┌──┐  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
└───┴──┴────┴──┴──>
    T-1      T    
Legend
  • T-1 (791a398): 241 MB
  • T (current commit): 241 MB

@jasonbarry jasonbarry force-pushed the chore/kebab-case-post-processing branch from 30f7d27 to 8cd7be4 Compare October 25, 2022 22:50
@jasonbarry jasonbarry requested a review from ShaneSaww October 25, 2022 23:16
@jasonbarry jasonbarry marked this pull request as ready for review October 25, 2022 23:16
@jasonbarry jasonbarry requested a review from a team as a code owner October 25, 2022 23:16
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasonbarry jasonbarry added the automerge Add to Kodiak auto merge queue label Oct 27, 2022
@kodiakhq kodiakhq bot merged commit fe76980 into main Oct 27, 2022
@kodiakhq kodiakhq bot deleted the chore/kebab-case-post-processing branch October 27, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Add to Kodiak auto merge queue type: chore work needed to keep the product and development running smoothly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants