Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Conversation

@nickytonline
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Updates the Remix dev command to remix dev. When the command was initially added, remix dev did not exist.

Closes #787


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This
    ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a
    typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Jul 14, 2022
@nickytonline nickytonline self-assigned this Jul 14, 2022
@nickytonline
Copy link
Contributor Author

I checked our docs and there is no mention of remix watch @KyleBlankRollins, so nothing to update there. There is only discussion of build commands for frameworks, including Remix, https://github.com/netlify/docs/blob/main/docs/integrations/frameworks/index.md#remix

@nickytonline nickytonline requested a review from sarahetter July 14, 2022 20:50
Copy link

@orinokai orinokai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw the discussion on Slack, but looks like it's all resolved so 🚢

@nickytonline nickytonline merged commit 7ac785e into main Jul 15, 2022
@nickytonline nickytonline deleted the nickytonline/update-remix-dev-command branch July 15, 2022 14:05
@ascorbic
Copy link
Contributor

Wait, I thought the decision was to not change this?

nickytonline added a commit that referenced this pull request Jul 15, 2022
kodiakhq bot pushed a commit that referenced this pull request Jul 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

type: chore work needed to keep the product and development running smoothly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the Remix dev command

4 participants