This repository was archived by the owner on Oct 10, 2022. It is now read-only.
Enable fp/no-mutating-methods ESLint rule
#241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: chore
ehmicky
commented
Dec 16, 2020
| // might live in two different locations | ||
|
|
||
| if (Array.isArray(shaMap[fileObj.hash])) { | ||
| // eslint-disable-next-line fp/no-mutating-methods |
Contributor
Author
There was a problem hiding this comment.
This code relies on streaming for performance reasons (hashing many files). Streaming relies on event handlers, which are hard to use in a purely functional way, which is why we need some mutation here.
There is a probably a way to do this in an incremental/performant way without mutation, but this could potentially break the logic.
erezrokah
approved these changes
Dec 16, 2020
ehmicky
force-pushed
the
chore/no-mutating-methods
branch
from
5dcb4ac to
38030aa
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the
fp/no-mutating-methodsESLint rule.