This repository was archived by the owner on Oct 10, 2022. It is now read-only.
Add fp/no-mutating-assigns ESLint rule
#242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: chore
ehmicky
commented
Dec 16, 2020
|
|
||
| const methods = getMethods(this) | ||
| // eslint-disable-next-line fp/no-mutating-assign | ||
| Object.assign(this, methods) |
Contributor
Author
There was a problem hiding this comment.
This needs to run after options have been assigned.
ehmicky
commented
Dec 16, 2020
| } | ||
|
|
||
| const getMethods = function (NetlifyApi) { | ||
| const getMethods = function ({ basePath, defaultHeaders, agent, globalParams }) { |
Contributor
Author
There was a problem hiding this comment.
Make options passing more explicit.
ehmicky
commented
Dec 16, 2020
| Object.assign(error, { name: 'FetchError', url, data }) | ||
| error.name = 'FetchError' | ||
| error.url = url | ||
| error.data = data |
Contributor
Author
There was a problem hiding this comment.
We allow direct mutations on variables that are known to be mutable by design. For example, errors should be directly mutated to keep the Error prototype. We allow those variables by variable names: https://github.com/netlify/eslint-config-node/blob/d76bd7afca8611d0a00277bdd24435adfdeca38b/.eslintrc.js#L181
However, the exceptions option is not available for this specific rule (about Object.assign()), so we need to use direct property mutations instead to fix linting.
erezrokah
approved these changes
Dec 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the
fp/no-mutating-assignsESLint rule.